From 9078c1c9cc65ed1ff98de7e9bb1b0a4dfffe2a11 Mon Sep 17 00:00:00 2001
From: Starknet Dev <42612612+starknetdev@users.noreply.github.com>
Date: Wed, 29 Jul 2026 09:39:36 -0700
Subject: [PATCH] fix(code-review): make the documented "." catch-all actually
 match
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

diff_paths are matched with startswith(), so the README's catch-all
example — diff_paths ["."] plus exclude_paths — only ever matched
dotfile paths. A repo whose PR touched just README.md, package.json or
Scarb.toml got no review at all, silently.

The failure is easy to miss because the pathspec half of the same value
is correct: `git diff -- . ':!packages/'` scopes exactly right, so the
agent reviews the right files on the runs where it does trigger.

Normalizes "." / "./" / "" to the empty prefix in the matcher (every
path startswith ""), and maps "" back to "." when building the git
pathspec, since "" is not a valid pathspec. Also documents that these
are literal prefixes, not globs — "src/**" matches nothing today and
gives no warning.

Verified no behavior change for existing callers: the patched and
original matchers produce identical output for denshokan-sdk's and
game-components' configs across 10 changed-file sets each.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .github/workflows/code-review.yml | 17 ++++++++++++++---
 README.md                         |  6 ++++++
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/code-review.yml b/.github/workflows/code-review.yml
index 4ffa607..cdeebc1 100644
--- a/.github/workflows/code-review.yml
+++ b/.github/workflows/code-review.yml
@@ -74,20 +74,31 @@ jobs:
           # not covered by its optional exclude_paths (so "general" can be
           # everything-except-app-dirs). Agents without exclude_paths behave
           # exactly as before.
+          #
+          # diff_paths / exclude_paths are matched as literal path PREFIXES, not
+          # globs — "packages/" matches "packages/foo/bar.cairo". A repo-root
+          # catch-all ("." or "./" or "") normalizes to the empty prefix, which
+          # every path starts with; without that, "." would only match dotfiles
+          # and a catch-all agent would silently skip README.md-only PRs.
           MATRIX_JSON=$(jq -c --argjson changed_files "$CHANGED_FILES_JSON" '
+          def norm_prefix: if . == "." or . == "./" or . == "" then "" else . end;
           {
             include: [
               .agents[]
               | . as $a
+              | (($a.diff_paths // []) | map(norm_prefix)) as $include_prefixes
+              | (($a.exclude_paths // []) | map(norm_prefix)) as $exclude_prefixes
               | select(
                   [ $changed_files[]
                     | . as $f
-                    | (($a.diff_paths // []) | any(. as $p | $f | startswith($p)))
-                      and (($a.exclude_paths // []) | any(. as $p | $f | startswith($p)) | not)
+                    | ($include_prefixes | any(. as $p | $f | startswith($p)))
+                      and ($exclude_prefixes | any(. as $p | $f | startswith($p)) | not)
                   ] | any
                 )
               | . + {
-                  diff_paths_str: (.diff_paths | join(" ")),
+                  # "" is a valid prefix but not a valid git pathspec; "." is
+                  # both, and means the same thing to git.
+                  diff_paths_str: (.diff_paths | map(if . == "" then "." else . end) | join(" ")),
                   exclude_paths_str: ((.exclude_paths // []) | map(":!" + .) | join(" "))
                 }
             ]
diff --git a/README.md b/README.md
index 25087de..cb57f83 100644
--- a/README.md
+++ b/README.md
@@ -74,6 +74,12 @@ review config and prompts.
    An agent runs only when the PR touches one of its `diff_paths`. Add more
    agents for different areas (each gets its own scoped prompt + PR comment).
 
+   `diff_paths` and `exclude_paths` are matched as **literal path prefixes,
+   not globs**: `"packages/"` matches `packages/foo/bar.cairo`, and
+   `"package.json"` matches only that file. Do not write `"src/**"` — `**` is
+   not special here, so the entry would match nothing. Use `"."` (or `""`) for
+   a repo-root catch-all that matches every changed file.
+
    Optional **`exclude_paths`** narrows an agent to "matched by `diff_paths`
    but not under these paths" — useful for a catch-all `general` agent that
    reviews everything *except* the app dirs: