Skip to content

getCollections all-chain integration coverage is skipped #1986

Description

@omerbek

Summary

test/integration/getCollection.spec.ts has an integration test for getCollections across supported chains, but it is currently skipped unconditionally:

test.skip("Get Collections for all chains", async () => {
  // Excluding Solana (no NFT collections)
  const chains = Object.values(Chain).filter(chain => chain !== Chain.Solana)
  // ...
})

Impact

getCollections can regress for non-mainnet chains without being caught by integration coverage. The active tests cover mainnet collection behavior, but the multi-chain path is disabled.

Expected behavior

The all-chain coverage should either run in the integration suite, or be conditionally gated with a clear reason if some chains are expected to be flaky/unavailable.

Possible fix

Convert the unconditional skip into a maintainable chain matrix, for example by:

  • testing a small stable allowlist of chains,
  • skipping only known unsupported/flaky chains with comments,
  • or making the all-chain test opt-in via an environment variable used by scheduled/manual CI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions