-
Notifications
You must be signed in to change notification settings - Fork 69
Refactor Filtering #2620
Copy link
Copy link
Open
Description
DanielLacina
opened on May 22, 2026
Issue body actions
- Add implicit type conversions which will enable the filters to compare only values in contrast to comparing their types. We want to create some sort of trait that guarantees that this logic occurs for all filters.
- Avoid exposing expression and other irrelevant methods on FilterBuilders (atm, we panic if an irrelevant method is called on NodeDegree which is undesirable). For example, Node.degree(direction).all() should not even be a part of the NodeDegreeFilterBuilder interface.
- Create traits that make the code more reusable which will lead to consistent logic and easier to maintain code. This will also avoid the exposing irrelevant methods that occurs from a Filter inheriting a coupled trait. Also, some methods and struct attributes end up storing garbage values because they are irrelevant to the actual logic of the Filter.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.