Skip to content

Refactor Filtering #2620

@DanielLacina

Description

@DanielLacina
  1. Add implicit type conversions which will enable the filters to compare only values in contrast to comparing their types. We want to create some sort of trait that guarantees that this logic occurs for all filters.
  2. Avoid exposing expression and other irrelevant methods on FilterBuilders (atm, we panic if an irrelevant method is called on NodeDegree which is undesirable). For example, Node.degree(direction).all() should not even be a part of the NodeDegreeFilterBuilder interface.
  3. Create traits that make the code more reusable which will lead to consistent logic and easier to maintain code. This will also avoid the exposing irrelevant methods that occurs from a Filter inheriting a coupled trait. Also, some methods and struct attributes end up storing garbage values because they are irrelevant to the actual logic of the Filter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions