Skip to content

Linux build failing #3

Description

@clort81

Hi Pickle! Thanks for all the great software.

A build with devuan and gcc-8 and
libopenal-dev is already the newest version (1:1.19.1-1).
libvorbis-dev is already the newest version (1.3.6-2).
libsdl1.2-dev is already the newest version (1:1.2.15-7+2m7.1)

is failing with

/pr/games/GishGLES/video/texture.c: In function ‘loadtexturepng’:
/pr/games/GishGLES/video/texture.c:98:14: error: dereferencing pointer to incomplete type ‘png_info’ {aka ‘struct png_info_def’}
  if (info_ptr->color_type == PNG_COLOR_TYPE_PALETTE)
              ^~

Websearch yields:

The png_info struct was removed from the png.h in 1.5.0 and now you should use this pointer with the png_get_* and png_set_* functions.

As specified in libpng manual:

"The png_info structure is designed to provide information about the PNG file. At one time, the fields of png_info were intended to be directly accessible to the user. However, this tended to cause problems with applications using dynamically loaded libraries, and as a result a set of interface functions for png_info (the png_get_() and png_set_() functions) was developed, and direct access to the png_info fields was deprecated.."

For example:

png_uint_32 height;
height = png_get_image_height( png_ptr,  info_ptr);

Is this something you can fix-up?

Cheers!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions