From 2679917799b5fe53ec9b3b8b106036adf22514a7 Mon Sep 17 00:00:00 2001 From: momo Date: Tue, 21 Jul 2026 23:33:50 +0100 Subject: [PATCH 1/2] Exit if bad JSON The next block expects good JSON anyway. --- src/Classes/TradeQueryRequests.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Classes/TradeQueryRequests.lua b/src/Classes/TradeQueryRequests.lua index 06e4bba2d7..53f3ec02d8 100644 --- a/src/Classes/TradeQueryRequests.lua +++ b/src/Classes/TradeQueryRequests.lua @@ -380,6 +380,7 @@ function TradeQueryRequestsClass:FetchLeagues(realm, callback) local json_data = dkjson.decode(response.body) if not json_data or json_data.error then errMsg = json_data and json_data.error or "Failed to parse trade leagues JSON" + return callback({"Standard", "Hardcore"}, errMsg) end local leagues = {} for _, value in pairs(json_data.result) do From 8367d13153eda832f3c1d1bba8abc1a19408181d Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Fri, 24 Jul 2026 07:57:31 +1000 Subject: [PATCH 2/2] Fix crash on table return --- src/Classes/TradeQueryRequests.lua | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Classes/TradeQueryRequests.lua b/src/Classes/TradeQueryRequests.lua index 53f3ec02d8..c1a912d426 100644 --- a/src/Classes/TradeQueryRequests.lua +++ b/src/Classes/TradeQueryRequests.lua @@ -379,7 +379,11 @@ function TradeQueryRequestsClass:FetchLeagues(realm, callback) end local json_data = dkjson.decode(response.body) if not json_data or json_data.error then - errMsg = json_data and json_data.error or "Failed to parse trade leagues JSON" + local apiError = json_data and json_data.error + errMsg = apiError or "Failed to parse trade leagues JSON" + if type(apiError) == "table" then + errMsg = apiError.message or (apiError.code and tostring(apiError.code)) or "Failed to parse trade leagues JSON" + end return callback({"Standard", "Hardcore"}, errMsg) end local leagues = {}