Preserve explicit carousel tab selections#4
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: pa7ch3s <Pa7ch3s@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and Impact
Selecting certain Core Areas carousel tabs could immediately revert to a neighboring tab after the smooth centering scroll settled. Reproduced in Chrome at 480px by clicking
AI Penetration Testingand seeing the panel revert toThick Clients, and at 1024px by clickingThick Clientsand seeing it revert toWeb3 / Blockchain Security.Root Cause
The scroll-sync debounce treated
scrollIntoViewmovement from explicit click/keyboard selection as passive user scrolling, recomputed the active tab from viewport center, and overwrote the user's selected panel.Fix
Mark explicit selections' centering scroll as programmatic, suppress the corresponding scroll-sync update, and initialize the active tab without triggering a centering scroll.
Validation
_blankrel safety, CSSurl()assets, and#focusPanelvisibility override.index.htmlandresume.htmlpassed.