Version schema-changing SPSS frontend submissions

Author: TonisOrmisson

src/openstatspec/frontends/spss/__init__.py

@@ -1,7 +1,12 @@
 """SPSS syntax frontend for canonical OpenStatSpec transformation plans."""
 
 from .binding import bind_spss_syntax
-from .compiler import SpssFrontendCompilation, compile_spss_syntax
+from .compiler import (
+    SPSS_FRONTEND_CONTRACT,
+    SPSS_FRONTEND_SCHEMA_CHANGE_CONTRACT,
+    SpssFrontendCompilation,
+    compile_spss_syntax,
+)
 from .syntax import (
     SpssSyntaxProgram,
     normalize_spss_source,
@@ -11,10 +16,9 @@
 )
 
 
-SPSS_FRONTEND_CONTRACT = "openstatspec-spss-syntax-frontend-v0.2"
-
 __all__ = [
     "SPSS_FRONTEND_CONTRACT",
+    "SPSS_FRONTEND_SCHEMA_CHANGE_CONTRACT",
     "SpssFrontendCompilation",
     "SpssSyntaxProgram",
     "bind_spss_syntax",

src/openstatspec/frontends/spss/compiler.py

@@ -4,7 +4,10 @@
 
 from dataclasses import dataclass
 
-from ...transform.plan import TransformationPlan
+from ...transform.plan import (
+    TRANSFORMATION_PLAN_SCHEMA_CHANGE_CONTRACT,
+    TransformationPlan,
+)
 from ...transform.schema import BoundTransformation, VariableSchema
 from .binding import bind_spss_syntax
 from .syntax import (
@@ -14,6 +17,10 @@
 )
 
 
+SPSS_FRONTEND_CONTRACT = "openstatspec-spss-syntax-frontend-v0.2"
+SPSS_FRONTEND_SCHEMA_CHANGE_CONTRACT = "openstatspec-spss-syntax-frontend-v0.3"
+
+
 @dataclass(frozen=True)
 class SpssFrontendCompilation:
     """One source artifact and its fully bound canonical plan."""
@@ -30,6 +37,12 @@ def plan(self) -> TransformationPlan:
     def plan_hash(self) -> str:
         return self.plan.sha256()
 
+    @property
+    def frontend_contract(self) -> str:
+        if self.plan.contract == TRANSFORMATION_PLAN_SCHEMA_CHANGE_CONTRACT:
+            return SPSS_FRONTEND_SCHEMA_CHANGE_CONTRACT
+        return SPSS_FRONTEND_CONTRACT
+
 
 def compile_spss_syntax(
     source: str,

src/openstatspec/frontends/spss/execution.py

@@ -10,7 +10,6 @@
     _run_in_place_submission,
     load_transformation_schema,
 )
-from . import SPSS_FRONTEND_CONTRACT
 from .compiler import compile_spss_syntax
 
 
@@ -37,7 +36,7 @@ def prepare(connection: Any, live_dataset_id: str) -> InPlacePlanSubmission:
             plan=compilation.plan,
             source_kind="spss_syntax",
             source_hash=compilation.source_hash,
-            frontend_contract=SPSS_FRONTEND_CONTRACT,
+            frontend_contract=compilation.frontend_contract,
         )
 
     return _run_in_place_submission(

src/openstatspec/transform/__init__.py

@@ -24,6 +24,7 @@
     "BoundTransformation",
     "RecodeMatch", "RecodeOperation", "RecodeResult",
     "RecodeRule", "ReplaceValueLabelsOperation", "SPSS_FRONTEND_CONTRACT",
+    "SPSS_FRONTEND_SCHEMA_CHANGE_CONTRACT",
     "SetFormatOperation", "SetMeasurementLevelOperation",
     "SetVariableLabelOperation", "SourcePosition", "SourceSpan", "StorageKind",
     "SpssFrontendCompilation",
@@ -42,6 +43,7 @@
 
 _SPSS_COMPAT_EXPORTS = {
     "SPSS_FRONTEND_CONTRACT",
+    "SPSS_FRONTEND_SCHEMA_CHANGE_CONTRACT",
     "SpssFrontendCompilation",
     "SpssSyntaxProgram",
     "bind_spss_syntax",

tests/test_inplace_transform.py

@@ -447,6 +447,25 @@ def test_public_apply_supports_non_dolt_without_building_undo(catalog) -> None:
     )
 
 
+def test_schema_commands_record_the_v03_frontend_contract(catalog) -> None:
+    url, path, dataset_id, _table_name = catalog
+
+    openstatspec.apply_spss_in_place(
+        database_url=url,
+        dataset_id=dataset_id,
+        source_text="STRING note (A4).",
+        actor="test-agent",
+    )
+
+    audit = sqlite3.connect(path).execute(
+        "SELECT source_kind, frontend_contract FROM transformation_apply"
+    ).fetchone()
+    assert audit == (
+        "spss_syntax",
+        "openstatspec-spss-syntax-frontend-v0.3",
+    )
+
+
 @pytest.mark.parametrize("as_mapping", [False, True])
 def test_public_generic_plan_apply_accepts_object_and_mapping(
     catalog, as_mapping,

tests/test_transform_frontend.py

@@ -368,6 +368,17 @@ def test_source_normalization_hash_and_positions_are_stable() -> None:
     assert compilation.source_text_lf == lf
     assert compilation.source_hash == spss_source_hash(lf)
     assert compilation.plan_hash == compilation.plan.sha256()
+    assert compilation.frontend_contract == "openstatspec-spss-syntax-frontend-v0.2"
+
+
+def test_schema_commands_use_the_v03_frontend_contract() -> None:
+    compilation = compile_spss_syntax(
+        "STRING note (A4).",
+        _schema(VariableDefinition("q1", "numeric")),
+    )
+
+    assert compilation.plan.contract == "openstatspec-transformation-plan-v0.3"
+    assert compilation.frontend_contract == "openstatspec-spss-syntax-frontend-v0.3"
 
 def test_string_comparison_fails_closed_until_exact_collation_is_supported() -> None:
     error = _error(