Skip to content

Update embedded-services workspace deps to main branch#99

Merged
tullom merged 1 commit into
OpenDevicePartnership:mainfrom
tullom:update-embedded-services-main
Jun 4, 2026
Merged

Update embedded-services workspace deps to main branch#99
tullom merged 1 commit into
OpenDevicePartnership:mainfrom
tullom:update-embedded-services-main

Conversation

@tullom

@tullom tullom commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

The battery-service-messages, time-alarm-service-messages, and thermal-service-messages crates no longer exist on the main branch of embedded-services. They have been split into separate *-service-interface (data types and traits) and *-service-relay (MCTP request/response message enums) crates.

Switch workspace and crate dependencies accordingly, update imports across test-cli, test-lib, test-script, and test-tui, rename AcpiBatteryRequest/Response variants to their shorter forms (e.g. BatteryGetBstRequest -> GetBst), wrap the thermal temperature field unwrap with .0 for the new DeciKelvin type, and switch BIX enum decoding to the standard TryFrom impls now that the bat_*/power_unit_try_from_u32 helpers are gone.

Pin embedded-mcu-hal to the published 0.2.0 release on crates.io to match the version that embedded-services pulls in transitively, and update the embedded-mcu-hal API usages (UncheckedDatetime -> DatetimeFields, to_unix_time_seconds -> unix_timestamp).

Assisted-by: GitHub Copilot:claude-opus-4.7

Copilot AI review requested due to automatic review settings June 2, 2026 21:07
@tullom tullom requested a review from a team as a code owner June 2, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the EC workspace’s embedded-services git dependencies for time-alarm-service-messages and battery-service-messages to track the main branch instead of v0.2.0, aligning the workspace with upstream embedded-services development.

Changes:

  • Switched time-alarm-service-messages workspace dependency from branch = "v0.2.0" to branch = "main".
  • Switched battery-service-messages workspace dependency from branch = "v0.2.0" to branch = "main".

Comment thread ec/Cargo.toml Outdated
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Cargo Vet Audit Passed

cargo vet has passed in this PR. No new unvetted dependencies were found.

@tullom tullom force-pushed the update-embedded-services-main branch from ec67ea9 to a3195a7 Compare June 2, 2026 21:19
kurtjd
kurtjd previously approved these changes Jun 2, 2026
@tullom tullom force-pushed the update-embedded-services-main branch from a3195a7 to f3e25f5 Compare June 2, 2026 21:49
@github-project-automation github-project-automation Bot moved this to In progress in ODP v0.2 Jun 2, 2026
jerrysxie
jerrysxie previously approved these changes Jun 2, 2026
@tullom tullom dismissed stale reviews from jerrysxie and kurtjd via 9d3e88c June 3, 2026 18:45
@tullom tullom force-pushed the update-embedded-services-main branch 2 times, most recently from 9d3e88c to 9993d22 Compare June 3, 2026 19:03
The battery-service-messages, time-alarm-service-messages, and thermal-service-messages crates no longer exist on the main branch of embedded-services. They have been split into separate *-service-interface (data types and traits) and *-service-relay (MCTP request/response message enums) crates.

Switch workspace and crate dependencies accordingly, update imports across test-cli, test-lib, test-script, and test-tui, rename AcpiBatteryRequest/Response variants to their shorter forms (e.g. BatteryGetBstRequest -> GetBst), wrap the thermal temperature field unwrap with .0 for the new DeciKelvin type, and switch BIX enum decoding to the standard TryFrom impls now that the bat_*/power_unit_try_from_u32 helpers are gone.

Pin embedded-mcu-hal to the published 0.2.0 release on crates.io to match the version that embedded-services pulls in transitively, and update the embedded-mcu-hal API usages (UncheckedDatetime -> DatetimeFields, to_unix_time_seconds -> unix_timestamp).

Assisted-by: GitHub Copilot:claude-opus-4.7
@tullom tullom force-pushed the update-embedded-services-main branch from 9993d22 to 32db859 Compare June 3, 2026 19:16
@tullom tullom requested review from jerrysxie and kurtjd June 3, 2026 19:19
@tullom tullom enabled auto-merge June 3, 2026 19:19
@tullom tullom self-assigned this Jun 3, 2026
@tullom tullom merged commit e5724c4 into OpenDevicePartnership:main Jun 4, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in ODP v0.2 Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants