changes to allow custom labels for ServiceMonitor#850
changes to allow custom labels for ServiceMonitor#850csauoss wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
csauoss
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
|
changes look good, @csauoss can you rebase please. |
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
8e8e5ec to
deb5368
Compare
@shivamerla Thanks for taking a look. pulled in changes from main and did the rebase. |
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
deb5368 to
9a049dc
Compare
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
9a049dc to
1a0f052
Compare
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
1a0f052 to
a2c5c59
Compare
|
@shivamerla can you please review it again when you get a chance? thanks! |
|
@csauoss @shivamerla It would be great to see this land, any updates on getting this into |
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
a2c5c59 to
20a2528
Compare
Signed-off-by: Saurabh Choudhary <csauoss@gmail.com>
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
20a2528 to
8837b55
Compare
|
@ramesius thanks for bumping this. I have rebased it and is ready for review again. Hoping for @shivamerla @cdesiniotis to take a look when they get a chance. |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
|
This pull request was automatically closed due to inactivity. |
|
Re-opening as it was autoclosed due to inactivity. This is a relevant PR and we want to take a look and see if we can get this in. |
rahulait
requested review from
karthikvetrivel,
rahulait and
rajathagasthya
as code owners
rahulait
removed
the
lifecycle/stale
|
@rahulait thanks for the update. I will rebase this as well soon. |
|
Thanks @csauoss. I'll try to get this prioritized and provide feedback so that you don't have to keep on rebasing it every now and then. |
| // +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true | ||
| // +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors.displayName="ServiceMonitor configuration for NVIDIA DCGM Exporter" | ||
| ServiceMonitor *DCGMExporterServiceMonitorConfig `json:"serviceMonitor,omitempty"` | ||
| ServiceMonitor *ServiceMonitorConfig `json:"serviceMonitor,omitempty"` |
There was a problem hiding this comment.
Renaming the struct is a breaking change for consumers importing this type in their Go code. A type alias could work for backward compatibility:
type DCGMExporterServiceMonitorConfig = ServiceMonitorConfig6 participants
This pr addresses issue 710 to allow passing custom labels for gpu-operator's ServiceMonitor.