[Feature]: Allow specific annotation to be set on dgcm-exporter pod's daemonset#2292
Open
MadJlzz wants to merge 2 commits intoNVIDIA:mainfrom
Open
[Feature]: Allow specific annotation to be set on dgcm-exporter pod's daemonset#2292MadJlzz wants to merge 2 commits intoNVIDIA:mainfrom
MadJlzz wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Author
|
Hello there maintainers 👋🏼 This is a naive approach to add extra annotations to |
…monSet Signed-off-by: Julien Klaer <klaer.julien@gmail.com>
… to the daemonset and it's underlying pods Signed-off-by: Julien Klaer <klaer.julien@gmail.com>
0758246 to
34c82f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support to set extra annotations to
dcgm-exporteronly.Solves #2271
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Added multiple units tests for now:
dcgm-exporterwhendaemonsets.annotationsis emptydcgm-exporteranddaemonsets.annotationswhen both are set