Skip to content

[Feature]: Allow specific annotation to be set on dgcm-exporter pod's daemonset#2292

Open
MadJlzz wants to merge 2 commits intoNVIDIA:mainfrom
MadJlzz:add-extra-annotation-dcgm-exporter-ds
Open

[Feature]: Allow specific annotation to be set on dgcm-exporter pod's daemonset#2292
MadJlzz wants to merge 2 commits intoNVIDIA:mainfrom
MadJlzz:add-extra-annotation-dcgm-exporter-ds

Conversation

@MadJlzz
Copy link
Copy Markdown

@MadJlzz MadJlzz commented Apr 13, 2026

Description

Add support to set extra annotations to dcgm-exporter only.
Solves #2271

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Added multiple units tests for now:

  • add annotations on dcgm-exporter when daemonsets.annotations is empty
  • combine annotations of dcgm-exporter and daemonsets.annotations when both are set

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@MadJlzz
Copy link
Copy Markdown
Author

MadJlzz commented Apr 13, 2026

Hello there maintainers 👋🏼

This is a naive approach to add extra annotations to dcgm-exporter daemonset as well as it's pod. I have nothing against reviewing the entire logic - this is my first time touching a Kubernetes operator.

MadJlzz added 2 commits April 13, 2026 23:53
…monSet

Signed-off-by: Julien Klaer <klaer.julien@gmail.com>
… to the daemonset and it's underlying pods

Signed-off-by: Julien Klaer <klaer.julien@gmail.com>
@MadJlzz MadJlzz force-pushed the add-extra-annotation-dcgm-exporter-ds branch from 0758246 to 34c82f0 Compare April 13, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant