From 45ed6f47f23c0d7a65003dbd981748ab6e9d5e30 Mon Sep 17 00:00:00 2001 From: darkdi Date: Thu, 6 Aug 2026 11:11:48 +0300 Subject: [PATCH 1/5] Fix Doxygen @param and @tparam names that do not match the declarations --- cpp/include/cudf/column/column_view.hpp | 4 ++-- cpp/include/cudf/detail/utilities/vector_factories.hpp | 8 -------- cpp/include/cudf/interop.hpp | 4 ---- cpp/include/cudf/utilities/traits.hpp | 4 ++-- cpp/include/cudf/utilities/type_dispatcher.hpp | 2 +- cpp/include/cudf_test/column_wrapper.hpp | 2 +- 6 files changed, 6 insertions(+), 18 deletions(-) diff --git a/cpp/include/cudf/column/column_view.hpp b/cpp/include/cudf/column/column_view.hpp index 67d105a6ebbe..24a020f257aa 100644 --- a/cpp/include/cudf/column/column_view.hpp +++ b/cpp/include/cudf/column/column_view.hpp @@ -56,7 +56,7 @@ class column_view_base { * This function will only participate in overload resolution if `is_rep_layout_compatible()` * or `std::is_same_v` are true. * - * @tparam The type to cast to + * @tparam T The type to cast to * @return Typed pointer to underlying data */ template ()` allocation of a * column, and instead, accessing the elements should be done via `data()`. * - * @tparam The type to cast to + * @tparam T The type to cast to * @return Typed pointer to underlying data */ template > make_device_uvector_async( * @note This function does not synchronize `stream`. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input host container from which to copy * @param stream The stream on which to allocate memory and perform the copy * @param mr The memory resource to use for allocating the returned device_uvector @@ -166,7 +165,6 @@ rmm::device_uvector> make_device_uvector_async( * @note This function does not synchronize `stream`. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input device container from which to copy * @param stream The stream on which to allocate memory and perform the copy * @param mr The memory resource to use for allocating the returned device_uvector @@ -210,7 +208,6 @@ rmm::device_uvector make_device_uvector(host_span source_data, * @note This function synchronizes `stream`. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input host container from which to copy * @param stream The stream on which to allocate memory and perform the copy * @param mr The memory resource to use for allocating the returned device_uvector @@ -273,7 +270,6 @@ rmm::device_uvector make_device_uvector(device_span source_data, * @note This function synchronizes `stream`. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input device container from which to copy * @param stream The stream on which to allocate memory and perform the copy * @param mr The memory resource to use for allocating the returned device_uvector @@ -316,7 +312,6 @@ std::vector> make_std_vector_async(device_span v, * @note This function synchronizes `stream` after the copy. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input device container from which to copy * @param stream The stream on which to perform the copy * @return The data copied to the host @@ -355,7 +350,6 @@ std::vector make_std_vector(device_span v, rmm::cuda_stream_view str * @note This function synchronizes `stream`. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input device container from which to copy * @param stream The stream on which to perform the copy * @return The data copied to the host @@ -430,7 +424,6 @@ host_vector make_host_vector_async(device_span v, rmm::cuda_stream_v * using a pinned memory resource. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input device container from which to copy * @param stream The stream on which to perform the copy * @return The data copied to the host @@ -470,7 +463,6 @@ host_vector make_host_vector(device_span v, rmm::cuda_stream_view st * @note This function synchronizes `stream` after the copy. * * @tparam Container The type of the container to copy from - * @tparam T The type of the data to copy * @param c The input device container from which to copy * @param stream The stream on which to perform the copy * @return The data copied to the host diff --git a/cpp/include/cudf/interop.hpp b/cpp/include/cudf/interop.hpp index cc3f68b1cf57..ccc000730e6d 100644 --- a/cpp/include/cudf/interop.hpp +++ b/cpp/include/cudf/interop.hpp @@ -323,8 +323,6 @@ class arrow_column { /** * @brief Get a view of the column data * - * @param stream CUDA stream used for device memory operations and kernel launches - * @param mr Device memory resource used for any allocations during conversion * @return A view of the column data */ [[nodiscard]] column_view view() const; @@ -443,8 +441,6 @@ class arrow_table { /** * @brief Get a view of the table data * - * @param stream CUDA stream used for device memory operations and kernel launches - * @param mr Device memory resource used for any allocations during conversion * @return A view of the table data */ [[nodiscard]] table_view view() const; diff --git a/cpp/include/cudf/utilities/traits.hpp b/cpp/include/cudf/utilities/traits.hpp index 0098c0626244..a424ab826e05 100644 --- a/cpp/include/cudf/utilities/traits.hpp +++ b/cpp/include/cudf/utilities/traits.hpp @@ -389,7 +389,7 @@ constexpr inline bool is_byte() /** * @brief Indicates whether `T` is a Boolean type. * - * @param type The `data_type` to verify + * @tparam T The type to verify * @return true `type` is Boolean * @return false `type` is not Boolean */ @@ -642,7 +642,7 @@ bool is_compound(data_type type); * can have an arbitrarily deep list of descendants of the same * type. Strings are not a nested type, but lists are. * - * @param T The type to verify + * @tparam T The type to verify * @return true T is a nested type * @return false T is not a nested type */ diff --git a/cpp/include/cudf/utilities/type_dispatcher.hpp b/cpp/include/cudf/utilities/type_dispatcher.hpp index 56f1c14942f4..4b563cc8752b 100644 --- a/cpp/include/cudf/utilities/type_dispatcher.hpp +++ b/cpp/include/cudf/utilities/type_dispatcher.hpp @@ -74,7 +74,7 @@ struct id_to_type_impl { * ``` * static_assert(std::is_same); * ``` - * @tparam t The `cudf::type_id` to map + * @tparam Id The `cudf::type_id` to map */ template using id_to_type = typename id_to_type_impl::type; diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index f0a7a64e3d29..227e526309b9 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -920,7 +920,7 @@ class strings_column_wrapper : public detail::column_wrapper { * This class handles fixed-width type keys. * * @tparam KeyElementTo Specify a fixed-width type for the key values of the dictionary - * @tparam SourceElementTo For converting fixed-width values to the KeyElementTo + * @tparam SourceElementT For converting fixed-width values to the KeyElementTo */ template class dictionary_column_wrapper : public detail::column_wrapper { From 329644f25a5fbebe6e07d5a882a6501a60b54a1f Mon Sep 17 00:00:00 2001 From: darkdi Date: Thu, 6 Aug 2026 16:11:58 +0300 Subject: [PATCH 2/5] Address review: fix the remaining Doxygen names in the files pointed out - column_device_view_base.cuh: name the head() template parameter - type_dispatcher.hpp: the parameter is IdTypeMap, id_to_type_impl is its default - iterator.cuh, range_utils.cuh, count_matches.hpp: name the template parameter - timestamp_utilities.cuh: Rep and Period are local aliases, the parameters are T and nullable - traits.hpp: the return descriptions refer to T, not to a data_type argument - column_wrapper.hpp: mark up KeyElementTo as code --- cpp/include/cudf/column/column_device_view_base.cuh | 4 ++-- cpp/include/cudf/detail/iterator.cuh | 2 +- cpp/include/cudf/utilities/traits.hpp | 12 ++++++------ cpp/include/cudf/utilities/type_dispatcher.hpp | 2 +- cpp/include/cudf_test/column_wrapper.hpp | 2 +- cpp/include/cudf_test/timestamp_utilities.cuh | 5 ++--- cpp/src/rolling/detail/range_utils.cuh | 2 +- cpp/src/strings/count_matches.hpp | 2 +- 8 files changed, 15 insertions(+), 16 deletions(-) diff --git a/cpp/include/cudf/column/column_device_view_base.cuh b/cpp/include/cudf/column/column_device_view_base.cuh index 161aa969f4e0..dcbf3b95292d 100644 --- a/cpp/include/cudf/column/column_device_view_base.cuh +++ b/cpp/include/cudf/column/column_device_view_base.cuh @@ -132,7 +132,7 @@ class alignas(16) column_device_view_base { * This function will only participate in overload resolution if `is_rep_layout_compatible()` * or `std::is_same_v` are true. * - * @tparam The type to cast to + * @tparam T The type to cast to * @return Typed pointer to underlying data */ template ()`. * - * @tparam The type to cast to + * @tparam T The type to cast to * @return Typed pointer to underlying data */ template constexpr inline bool is_byte() @@ -390,8 +390,8 @@ constexpr inline bool is_byte() * @brief Indicates whether `T` is a Boolean type. * * @tparam T The type to verify - * @return true `type` is Boolean - * @return false `type` is not Boolean + * @return true `T` is Boolean + * @return false `T` is not Boolean */ template constexpr inline bool is_boolean() @@ -643,8 +643,8 @@ bool is_compound(data_type type); * type. Strings are not a nested type, but lists are. * * @tparam T The type to verify - * @return true T is a nested type - * @return false T is not a nested type + * @return true `T` is a nested type + * @return false `T` is not a nested type */ template CUDF_HOST_DEVICE constexpr inline bool is_nested() diff --git a/cpp/include/cudf/utilities/type_dispatcher.hpp b/cpp/include/cudf/utilities/type_dispatcher.hpp index 4b563cc8752b..5af111978626 100644 --- a/cpp/include/cudf/utilities/type_dispatcher.hpp +++ b/cpp/include/cudf/utilities/type_dispatcher.hpp @@ -443,7 +443,7 @@ using scalar_device_type_t = typename type_to_scalar_type_impl::ScalarDeviceT * lambda must be the same, else there will be a compiler error as you would be * trying to return different types from the same function. * - * @tparam id_to_type_impl Maps a `cudf::type_id` its dispatched C++ type + * @tparam IdTypeMap Maps a `cudf::type_id` its dispatched C++ type * @tparam Functor The callable object's type * @tparam Ts Variadic parameter pack type * @param dtype The `cudf::data_type` whose `id()` determines which template diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index 227e526309b9..63e788b5d232 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -920,7 +920,7 @@ class strings_column_wrapper : public detail::column_wrapper { * This class handles fixed-width type keys. * * @tparam KeyElementTo Specify a fixed-width type for the key values of the dictionary - * @tparam SourceElementT For converting fixed-width values to the KeyElementTo + * @tparam SourceElementT For converting fixed-width values to the `KeyElementTo` */ template class dictionary_column_wrapper : public detail::column_wrapper { diff --git a/cpp/include/cudf_test/timestamp_utilities.cuh b/cpp/include/cudf_test/timestamp_utilities.cuh index 62b8a1c8db87..5a2d36452c67 100644 --- a/cpp/include/cudf_test/timestamp_utilities.cuh +++ b/cpp/include/cudf_test/timestamp_utilities.cuh @@ -26,9 +26,8 @@ using time_point_ms = * The period is inferred from `count` and difference between `start` * and `stop`. * - * @tparam Rep The arithmetic type representing the number of ticks - * @tparam Period A cuda::std::ratio representing the tick period (i.e. the - *number of seconds per tick) + * @tparam T The timestamp type of the generated column's elements + * @tparam nullable Whether the generated column carries a validity mask * @param count The number of timestamps to create * @param start The first timestamp as a cuda::std::chrono::time_point * @param stop The last timestamp as a cuda::std::chrono::time_point diff --git a/cpp/src/rolling/detail/range_utils.cuh b/cpp/src/rolling/detail/range_utils.cuh index 402e03b0bbb6..a949bf4f716d 100644 --- a/cpp/src/rolling/detail/range_utils.cuh +++ b/cpp/src/rolling/detail/range_utils.cuh @@ -567,7 +567,7 @@ struct range_window_clamper { /** * @brief Is the given type supported as an orderby column. * - * @tparam The type of the elements of the orderby column. + * @tparam OrderbyT The type of the elements of the orderby column. */ template static constexpr bool is_supported() diff --git a/cpp/src/strings/count_matches.hpp b/cpp/src/strings/count_matches.hpp index a948f8e68b7c..8f445836020d 100644 --- a/cpp/src/strings/count_matches.hpp +++ b/cpp/src/strings/count_matches.hpp @@ -29,7 +29,7 @@ namespace detail { * also need the device program for other work (e.g. extraction) should build it once * and pass it here to avoid a redundant device program build. * - * @tparam The regex prog device instance used for this API + * @tparam ProgDevice The regex prog device instance used for this API * @param d_strings Device view of the input strings column * @param d_prog Device regex program to evaluate on each string * @param strings_count Number of strings (and rows in the output column) From f1138e6101ba5add94d8707ae3a223a689149252 Mon Sep 17 00:00:00 2001 From: Igor Peshansky Date: Fri, 7 Aug 2026 14:03:23 -0400 Subject: [PATCH 3/5] Update copyrights. Signed-off-by: Igor Peshansky --- cpp/include/cudf/detail/iterator.cuh | 2 +- cpp/include/cudf/detail/utilities/vector_factories.hpp | 2 +- cpp/include/cudf_test/column_wrapper.hpp | 2 +- cpp/include/cudf_test/timestamp_utilities.cuh | 2 +- cpp/src/rolling/detail/range_utils.cuh | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cpp/include/cudf/detail/iterator.cuh b/cpp/include/cudf/detail/iterator.cuh index 9a3f4f416fd5..f9e76dfe0ca9 100644 --- a/cpp/include/cudf/detail/iterator.cuh +++ b/cpp/include/cudf/detail/iterator.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ diff --git a/cpp/include/cudf/detail/utilities/vector_factories.hpp b/cpp/include/cudf/detail/utilities/vector_factories.hpp index 8adcaafd9758..00c5c4048128 100644 --- a/cpp/include/cudf/detail/utilities/vector_factories.hpp +++ b/cpp/include/cudf/detail/utilities/vector_factories.hpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index 63e788b5d232..ac161813dc21 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ diff --git a/cpp/include/cudf_test/timestamp_utilities.cuh b/cpp/include/cudf_test/timestamp_utilities.cuh index 5a2d36452c67..7065e5bcce42 100644 --- a/cpp/include/cudf_test/timestamp_utilities.cuh +++ b/cpp/include/cudf_test/timestamp_utilities.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2019-2024, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ diff --git a/cpp/src/rolling/detail/range_utils.cuh b/cpp/src/rolling/detail/range_utils.cuh index a949bf4f716d..f7678ef6146f 100644 --- a/cpp/src/rolling/detail/range_utils.cuh +++ b/cpp/src/rolling/detail/range_utils.cuh @@ -1,5 +1,5 @@ /* - * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. + * SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. * SPDX-License-Identifier: Apache-2.0 */ From bb10c808c5f550bd0316bf3d603cb64d71fa9b3f Mon Sep 17 00:00:00 2001 From: Dmitry <45711841+darkdi@users.noreply.github.com> Date: Mon, 10 Aug 2026 10:50:58 +0300 Subject: [PATCH 4/5] Align the dictionary SourceElementT wording with fixed_width_column_wrapper --- cpp/include/cudf_test/column_wrapper.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index ac161813dc21..632a24155cf2 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -920,7 +920,8 @@ class strings_column_wrapper : public detail::column_wrapper { * This class handles fixed-width type keys. * * @tparam KeyElementTo Specify a fixed-width type for the key values of the dictionary - * @tparam SourceElementT For converting fixed-width values to the `KeyElementTo` + * @tparam SourceElementT The fixed-width element type that is used to create elements of type + * `KeyElementTo` */ template class dictionary_column_wrapper : public detail::column_wrapper { From c084842489168dbcfc7d32ac8a9a31af1309ba40 Mon Sep 17 00:00:00 2001 From: Dmitry <45711841+darkdi@users.noreply.github.com> Date: Mon, 10 Aug 2026 10:51:09 +0300 Subject: [PATCH 5/5] Fix the IdTypeMap typo pointed out in review --- cpp/include/cudf/utilities/type_dispatcher.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/include/cudf/utilities/type_dispatcher.hpp b/cpp/include/cudf/utilities/type_dispatcher.hpp index 5af111978626..074cee275a39 100644 --- a/cpp/include/cudf/utilities/type_dispatcher.hpp +++ b/cpp/include/cudf/utilities/type_dispatcher.hpp @@ -443,7 +443,7 @@ using scalar_device_type_t = typename type_to_scalar_type_impl::ScalarDeviceT * lambda must be the same, else there will be a compiler error as you would be * trying to return different types from the same function. * - * @tparam IdTypeMap Maps a `cudf::type_id` its dispatched C++ type + * @tparam IdTypeMap Maps a `cudf::type_id` to its dispatched C++ type * @tparam Functor The callable object's type * @tparam Ts Variadic parameter pack type * @param dtype The `cudf::data_type` whose `id()` determines which template