Validate pencil halo and padding extents#145
Merged
romerojosh merged 1 commit intoJun 24, 2026
Merged
Conversation
romerojosh
reviewed
Jun 24, 2026
romerojosh
left a comment
romerojosh
left a comment
Collaborator
There was a problem hiding this comment.
Hi @fallintoplace, thanks for the contribution. Left a comment for you to address with this one.
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/validate-pencil-extents
branch
from
8355fcd to
f56a257
Compare
romerojosh
approved these changes
Jun 24, 2026
romerojosh
left a comment
romerojosh
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Will merge once build and tests pass. Thanks for the contribution.
| } | ||
| } | ||
|
|
||
| TEST_F(ApiGetPencilInfoTest, DescribesEmptyPencils) { |
Collaborator
There was a problem hiding this comment.
Thanks for adding this test to enforce the current empty pencil support!
Collaborator
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cudecompGetPencilInfo.int32_tshape fields while preserving valid zero-sized empty pencils.int64_t, including zero-size handling.Validation
git diff --check