OpenShift follow-up for NVBugs 6218358 (26.05)#2167
Conversation
Document RC9 QA findings: prebuilt ffmpeg image on restricted-v2, openshift-restricted values profile, internal registry pull secrets, optional NIM LD_LIBRARY_PATH overrides, and Omni caption smoke-test request shape. Cross-link from deployment-options and prerequisites-support-matrix.
Greptile SummaryThis PR backports OpenShift deployment documentation to the
|
| Filename | Overview |
|---|---|
| nemo_retriever/helm/README.md | Large new #openshift-deployment section (~320 lines) covering SCC/PSA overrides, ffmpeg prebuilt image pattern, internal registry pull secrets, LD_LIBRARY_PATH env, and Omni caption smoke-test guidance; also corrects service.installFfmpeg default from false to true (matches actual values.yaml) and converts see → refer to throughout. |
| docs/docs/extraction/deployment-options.md | Expanded ffmpeg paragraph to name installFfmpeg=true as the chart default and adds cross-link to the new #openshift-deployment README section; also replaces see with refer to for consistency. |
| docs/docs/extraction/prerequisites-support-matrix.md | Minor editorial pass: see → refer to, via → through; ffmpeg guidance shortened to a cross-link to audio-video.md which already covers container/Helm ffmpeg setup; adds Image captioning scope note. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[helm install retriever] --> B{OpenShift?}
B -- No --> C[Generic K8s path\nstock defaults]
B -- Yes --> D[Apply openshift-restricted.yaml\n- runAsNonRoot only\n- allowPrivilegeEscalation: false\n- capabilities drop ALL\n- seccompProfile: RuntimeDefault]
D --> E{Need audio/video?}
E -- No --> F[service.installFfmpeg=false]
E -- Yes --> G[Build prebuilt service image\nFROM nrl-service + ffmpeg\nPush to NGC / internal registry]
G --> H[service.image.repository/tag\npoint at prebuilt image]
D --> I{Internal registry?}
I -- Yes --> J[imagePullSecrets: default-dockercfg-xxxxx\nngcImagePullSecret.name: empty]
I -- NGC only --> K[imagePullSecrets: ngc-secret]
D --> L{Optional NIMs crash?}
L -- Yes --> M[Add LD_LIBRARY_PATH via\nnimOperator.audio.env / omni.env]
D --> N{vectordb enabled?}
N -- Yes --> O[oc patch deployment\nadd securityContext block]
N -- No --> P[serviceConfig.vectordb.enabled=false]
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
nemo_retriever/helm/README.md:499-505
**Omni smoke-test request body missing image content**
The sample JSON uses a plain string `"content": "..."` which sends a text-only request to the VLM NIM. Nemotron 3 Nano Omni is a vision–language model, so an actual caption smoke test needs the content to be a multimodal array containing an `image_url` entry (following the OpenAI vision format). Sending this exact body will exercise the `enable_thinking` flag but won't test image captioning — the model will receive no image to caption, which could mask misconfiguration in the caption pipeline.
Consider replacing `"content": "..."` with the multimodal array form, for example:
`"content": [{"type": "image_url", "image_url": {"url": "data:image/png;base64,<BASE64>"}}, {"type": "text", "text": "Describe this image."}]`
Reviews (5): Last reviewed commit: "Merge upstream/26.05 into docs/6218358-o..." | Re-trigger Greptile
| --- | ||
| ## Air-gapped deployment { #air-gapped-deployment } |
There was a problem hiding this comment.
Missing blank line between the horizontal rule closing the OpenShift section and the
## Air-gapped deployment heading. While most Markdown parsers handle this, MkDocs (and strict CommonMark renderers) expect a blank line after a --- thematic break before the next block element to guarantee it is not parsed as a setext heading underline for any preceding content.
| --- | |
| ## Air-gapped deployment { #air-gapped-deployment } | |
| --- | |
| ## Air-gapped deployment { #air-gapped-deployment } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/helm/README.md
Line: 1246-1247
Comment:
Missing blank line between the horizontal rule closing the OpenShift section and the `## Air-gapped deployment` heading. While most Markdown parsers handle this, MkDocs (and strict CommonMark renderers) expect a blank line after a `---` thematic break before the next block element to guarantee it is not parsed as a setext heading underline for any preceding content.
```suggestion
---
## Air-gapped deployment { #air-gapped-deployment }
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Use neutral link labels to helm README anchors (26.05 branch URLs).
Add #1-service-image anchor, Parakeet OpenShift caveat, and soften Omni caption matrix cross-link on 26.05.
Correct installFfmpeg default drift, fix internal-registry pull-secret guidance, restore matrix page roles, and tighten deployment-options prose.
Replace see with refer to before links, fix via/e.g. in PR-scoped prose, and align OpenShift section wording.
Resolve prerequisites-support-matrix.md conflicts: keep PR page-role ffmpeg cross-link and upstream nemotron-parse requirement; adopt upstream OCR v1 content with PR style-guide refer-to wording.
Summary
26.05: expands Helm README OpenShift guidance per QA RC9 validation (NVBugs 6218358 comment Update README.md #6).#openshift-deploymentsection (not yet on26.05) plus RC9 follow-up items: prebuilt ffmpeg image on restricted-v2,openshift-restricted.yamlprofile, internal registry pull secrets, optional NIMLD_LIBRARY_PATHoverrides, and Omni caption manual smoke-test request shape.deployment-options.mdandprerequisites-support-matrix.md(blob/26.05/...URLs).NVBugs
6218358 — OpenShift Helm chart SCC/PodSecurity documentation follow-up (comment #6).
PR scope check
26.05nemo_retriever/helm/README.md,docs/docs/extraction/deployment-options.md,docs/docs/extraction/prerequisites-support-matrix.md.cursor/, link-audit artifacts, chart/code changes)26.05 doc rules (pre-merge)
nimOperator/nvcr.ioleakage off matrix + helmblob/26.05/...Test plan
helm lint nemo_retriever/helm(docs only)#openshift-deploymentanchors in Helm README on26.05