Skip to content

OpenShift follow-up for NVBug 6218358#2166

Open
kheiss-uwzoo wants to merge 16 commits into
NVIDIA:mainfrom
kheiss-uwzoo:docs/6218358-openshift-followup
Open

OpenShift follow-up for NVBug 6218358#2166
kheiss-uwzoo wants to merge 16 commits into
NVIDIA:mainfrom
kheiss-uwzoo:docs/6218358-openshift-followup

Conversation

@kheiss-uwzoo

@kheiss-uwzoo kheiss-uwzoo commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds docs/docs/extraction/openshift.md as the canonical OpenShift install guide (restricted-v2 / PSA restricted): openshift-restricted.yaml profile, prebuilt ffmpeg service image, internal registry pull secrets (ngcImagePullSecret.name: ""), optional NIM LD_LIBRARY_PATH overrides, direct Omni NIM /v1/chat/completions example, service-only and NIM Operator install flows, and post-install pod/NIMService checks.
  • Trims nemo_retriever/helm/README.md to a short #openshift-deployment stub plus cross-links into openshift.md; chart values and generic Kubernetes guidance stay in the Helm README.
  • Fixes deploy leakage in prerequisites-support-matrix.md (Software Requirements ffmpeg bullet → one line to audio-video.md; removed matrix Omni smoke-test cross-link).
  • Updates deployment-options.md and docs/mkdocs.yml nav to point at openshift.md.
  • Addresses Randy review: no QA phrasing; install sections describe user actions; OpenShift content moved out of the Helm README per follow-up request.

NVBugs

6218358 — OpenShift Helm chart SCC/PodSecurity documentation follow-up (comment #6).

PR scope check

  • Base: main
  • Files changed: docs/docs/extraction/openshift.md (new), docs/docs/extraction/deployment-options.md, docs/docs/extraction/prerequisites-support-matrix.md, docs/mkdocs.yml, nemo_retriever/helm/README.md
  • Red flags: none (docs only; no .cursor/, link-audit artifacts, chart/code changes)

Test plan

  • Confirm openshift.md renders on docs site (mkdocs nav entry under Deployment options)
  • Verify Helm README #openshift-deployment stub links to openshift.md
  • Confirm prerequisites matrix Software Requirements has no Helm/OpenShift/air-gap deploy prose
  • Spot-check OpenShift install examples read as user procedures (no QA references)

Document RC9 QA findings: prebuilt ffmpeg image on restricted-v2, openshift-restricted values profile, internal registry pull secrets, optional NIM LD_LIBRARY_PATH overrides, and Omni caption smoke-test request shape. Cross-link from deployment-options and prerequisites-support-matrix.
@kheiss-uwzoo kheiss-uwzoo requested review from a team as code owners May 29, 2026 16:15
@kheiss-uwzoo kheiss-uwzoo requested a review from charlesbluca May 29, 2026 16:15
@kheiss-uwzoo kheiss-uwzoo changed the title docs(helm): OpenShift follow-up for NVBugs 6218358 OpenShift follow-up for NVBugs 6218358 May 29, 2026
@greptile-apps

greptile-apps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR moves the OpenShift deployment guide out of the Helm README into a new canonical page (docs/docs/extraction/openshift.md) and trims the Helm README's OpenShift section to a cross-linking stub. It also fixes the air-gapped values snippet by explicitly setting ngcImagePullSecret.name: "" to prevent the ngc-secret default from being injected on mirror-only installs.

  • New openshift.md: covers restricted-v2/PSA-restricted value overrides, prebuilt ffmpeg image Dockerfile, internal registry pull-secret scenarios, full copy-paste-safe env lists for Parakeet and Omni NIMs, service-only and NIM Operator install examples, and vectordb/OTel post-install patches.
  • Helm README: OpenShift prose collapsed to a one-sentence stub + cross-link; air-gapped snippet gains name: "" fix; "see" → "refer to" wording pass throughout.
  • mkdocs.yml: new nav entry under "3. Deployment options" pointing at extraction/openshift.md.

Confidence Score: 5/5

Documentation-only change; no code, chart templates, or CI paths are modified.

All five changed files are Markdown or a YAML nav file. The new OpenShift guide is technically accurate, the previously flagged ngcImagePullSecret.name: "" fix is correctly applied in the air-gapped snippet, and the optional-NIM env lists are now copy-paste complete. No runtime behaviour changes.

No files require special attention.

Important Files Changed

Filename Overview
docs/docs/extraction/openshift.md New canonical OpenShift guide covering restricted-v2/PSA-restricted overrides, prebuilt ffmpeg image, internal registry pull secrets, full env lists for optional NIMs, and install examples for service-only and NIM Operator flows.
nemo_retriever/helm/README.md OpenShift section collapsed to a one-paragraph stub with cross-link; air-gapped snippet now sets name: "" to clear the ngc-secret default; "see" → "refer to" wording pass; OpenShift ffmpeg note added to the audio/video section.
docs/docs/extraction/deployment-options.md ffmpeg paragraph now names OpenShift restricted-v2 as a blocked path and links to openshift.md; minor "see" → "refer to" wording clean-up.
docs/docs/extraction/prerequisites-support-matrix.md ffmpeg bullet trimmed to a single line pointing to audio-video.md; "see" → "refer to" wording pass across footnotes and notes.
docs/mkdocs.yml Added "OpenShift deployment" nav entry under "3. Deployment options", pointing at the new extraction/openshift.md page.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User: Install on OpenShift] --> B{Audio/Video needed?}
    B -- No --> C[Use openshift-restricted.yaml\nservice.installFfmpeg=false]
    B -- Yes --> D[Build custom ffmpeg image\nFROM nrl-service + apt install ffmpeg]
    D --> E[Push to internal registry or NGC]
    E --> F[Set service.image.repository/tag\nin openshift-restricted.yaml]
    C --> G{In-cluster NIMs?}
    F --> G
    G -- No --> H[helm install\n--set nims.enabled=false\n--set persistence.enabled=false]
    G -- Yes --> I[Install NIM Operator + GPU Operator\nthen helm install with NIM Operator flags]
    H --> J[oc get pods\nVerify SCC-assigned numeric UID]
    I --> K[oc get pods\noc get nimservice]
    K --> L{ASR/Omni CrashLoop?}
    L -- Yes --> M[Add LD_LIBRARY_PATH overrides\nto nimOperator.audio.env /\nnimOperator.nemotron_3_nano_omni.env]
    L -- No --> N[Ready]
    M --> N
    J --> N
Loading

Reviews (12): Last reviewed commit: "Merge branch 'main' into docs/6218358-op..." | Re-trigger Greptile

Comment thread nemo_retriever/helm/README.md Outdated
Move Omni smoke-test note out of the chart admonition; use neutral link label to helm README anchor.
@kheiss-uwzoo kheiss-uwzoo changed the title OpenShift follow-up for NVBugs 6218358 docs(helm): OpenShift follow-up for NVBugs 6218358 May 29, 2026
Add explicit #1-service-image anchor and Parakeet step-4 OpenShift caveat for installFfmpeg.
@kheiss-uwzoo kheiss-uwzoo changed the title docs(helm): OpenShift follow-up for NVBugs 6218358 OpenShift follow-up for NVBug 6218358 May 29, 2026
Comment thread nemo_retriever/helm/README.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
@kheiss-uwzoo kheiss-uwzoo added the doc Improvements or additions to documentation label May 29, 2026
Resolve conflict in helm README OpenShift smoke-test example: keep
service.image repository/tag overrides from the PR branch.
Replace matrix smoke-test prose with a one-line helm link per page roles.
Show full nimOperator env lists in OpenShift LD_LIBRARY_PATH examples so
Helm list overrides do not drop chart defaults.
Comment thread docs/docs/extraction/prerequisites-support-matrix.md Outdated
Comment thread docs/docs/extraction/prerequisites-support-matrix.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Move Helm, OpenShift, and Omni smoke-test guidance out of the support
matrix so deployment details stay on audio-video.md and the Helm README.
Extract restricted-v2 install procedures from the Helm README into
docs/docs/extraction/openshift.md per review feedback. Helm README keeps
a stub with cross-links; deployment-options and mkdocs nav point to the
new page. Remove QA phrasing and fix ngcImagePullSecret name clearing.
Rewrite service-only and NIM Operator install intros as user actions
instead of validation or QA repro language, per review on PR 2166.
Replace the removed QA validation paragraph with user-facing pod and
NIMService checks plus guidance when optional ASR or Omni NIMs fail.
@kheiss-uwzoo kheiss-uwzoo requested a review from randerzander June 3, 2026 23:10
Clarify internal-registry pull secret wording and replace see-with-link CTAs with refer to so check-nrl-doc-leakage passes on PR 2166 files.
Replace via/once wording, drop code from headings, disambiguate caption links, and fix split refer-to link CTAs in the Helm README.
@kheiss-uwzoo kheiss-uwzoo requested a review from jperez999 June 8, 2026 18:14
Clarify air-gap ngcImagePullSecret.name clearing and add copy-paste-safe LD_LIBRARY_PATH env examples with explicit chart defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants