Forward-merge release/0.8 into main - #903
Merged
Merged
Conversation
#### Overview Add transparent forwarding for OpenAI image-generation requests so Codex Pets and other clients can use `POST /v1/images/generations` through the NeMo Relay gateway. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Register `/v1/images/generations` as an OpenAI gateway route. - Reuse the configured OpenAI base URL, authentication normalization, query-string forwarding, and request-size limit. - Forward image requests outside the managed text-generation pipeline because Relay does not have image request/response codecs. - Preserve upstream status, headers, and response bytes without synthesizing LLM observability events. - Add route, authentication, URL-normalization, and end-to-end forwarding coverage. Validation: - `just test-rust` - `cargo fmt --all` - `cargo clippy --workspace --all-targets -- -D warnings` - `uv run pre-commit run --all-files` #### Where should the reviewer start? Start with `crates/cli/src/gateway/mod.rs` and the `images_generations` handler. The key design decision is to use transparent upstream forwarding rather than treating the distinct image API payload as a managed text-generation call without a compatible codec. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: [RELAY-788](https://linear.app/nvidia/issue/RELAY-788/codex-pets-error-with-nemo-relay) ## Summary by CodeRabbit - **New Features** - Added support for OpenAI-compatible image generation requests. - Image-generation requests are transparently forwarded while preserving request details and authorization. - Added compatible OpenAI and ChatGPT authentication for image-generation requests. - **Bug Fixes** - Codex gateway URLs now consistently include the required `/v1` path. - Existing Codex configurations with legacy or trailing-slash URLs remain supported. - **Documentation** - Added upgrade guidance for refreshing persistent Codex integration settings. - **Tests** - Added coverage for routing, forwarding, authentication, URL normalization, and upstream request handling. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Bryan Bednarski (https://github.com/bbednarski9) URL: #900
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.8 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.