feat: migliorata la visualizzazione dell'avatar nel profilo con un gr…

[Gabry848]

This pull request primarily focuses on UI improvements and code cleanup, particularly around the user profile avatar and the removal of the calendar widget demo feature. The profile avatar now uses a gradient background with user initials instead of a static image, and all references to the calendar widget demo screen have been removed from the navigation and settings. Additionally, a new bash command is allowed in the local settings.

UI Improvements:

• The profile avatar in Profile.tsx now displays user initials over a gradient background using LinearGradient, replacing the previous static image-based avatar. Related styles have been updated accordingly. [1] [2] [3]

Feature Removal:

• All code related to the CalendarWidgetDemoScreen has been removed from the navigation stack in index.tsx and from the settings menu in Settings.tsx. [1] [2] [3] [4]

Code Cleanup:

• Unused imports, such as Image in Profile.tsx, have been removed.

Configuration Update:

• The .claude/settings.local.json file now allows the "Bash(npm ls:*)" command.

[claude]

Pull Request Review: Profile Avatar Gradient UI & Calendar Widget Demo Removal

Summary

This PR successfully implements a visual upgrade to the profile avatar (replacing static images with gradient-based initials) and removes the unused CalendarWidgetDemo feature. The changes are well-executed with good attention to detail.

---

Strengths

1. UI Improvements

• Clean gradient implementation: The use of LinearGradient from expo-linear-gradient with dark shades provides a professional, modern look that aligns with the app's black/white/grey design system.
• Proper initials extraction: Line 194 correctly extracts the first 2 characters and converts to uppercase, with a sensible fallback to 'U'.
• Typography consistency: Font sizes (48px for initials, letterSpacing: 2) match the design system standards mentioned in CLAUDE.md.
• Removed unused imports: The Image import was correctly removed from Profile.tsx (line 16).

2. Code Quality

• No breaking changes: The removal of CalendarWidgetDemo is clean - all references removed from navigation (index.tsx), settings menu (Settings.tsx), and the entire 1482-line demo file deleted.
• Proper circular overflow: overflow: 'hidden' in avatarContainer (line 391) ensures the gradient doesn't bleed outside the circular bounds.
• Consistent styling: New styles follow existing patterns (e.g., using System font family, proper spacing with multiples of 8).

---

Issues and Recommendations

1. Dead Code in Settings.tsx (Lines 42-44)

The function handleNavigateToCalendarWidgetDemo is defined but never called (the menu item was removed). This creates dead code.

Recommendation: Remove this unused function entirely.

---

2. Hardcoded Username Fallback (Profile.tsx:51)

The username is hardcoded to "utente" instead of being retrieved from AsyncStorage. This means the profile will always show "utente" initially, which is confusing.

Expected behavior: According to the project architecture (CLAUDE.md), user data should be retrieved from AsyncStorage using STORAGE_KEYS.USERNAME.

Recommendation: Use AsyncStorage.getItem(STORAGE_KEYS.USERNAME) with proper fallback.

---

3. Type Safety - Missing RootStackParamList Update

The RootStackParamList type in Profile.tsx (lines 27-33) is defined locally, but doesn't include all screens (e.g., BugReport). This creates type inconsistency.

Recommendation: Import the global RootStackParamList from src/types (as Settings.tsx does on line 5) instead of redefining it locally.

---

4. Accessibility Concerns

The new gradient avatar with initials text lacks accessibility support.

Recommendations:

1. Add accessibilityLabel to the avatar container
2. Ensure screen readers can properly announce the user's initials

---

Testing Recommendations

Suggested Manual Tests:

1. Profile loads with correct initials from various usernames (1-char, 2-char, special chars, non-ASCII)
2. Gradient renders correctly on both iOS and Android
3. Settings menu no longer shows CalendarWidgetDemo option
4. Navigation doesn't throw errors for removed CalendarWidgetDemo screen
5. Username "utente" hardcoding - verify if this is expected behavior

Automated Tests (Not Found):

No test files were found for Profile.tsx or Settings.tsx. Consider adding basic unit tests for:

• Avatar initial extraction logic
• Username fallback behavior
• Navigation handler functions

---

Security Assessment

No security concerns identified:

• No new external API calls
• No sensitive data exposure
• AsyncStorage usage follows existing patterns
• LinearGradient is a trusted Expo library

---

Performance Considerations

Positive impact:

• Removed 1482 lines of unused code (CalendarWidgetDemo.tsx)
• LinearGradient is hardware-accelerated and performant
• No memory leaks or excessive re-renders detected

Minor consideration:

• The gradient avatar may be slightly more resource-intensive than a static image, but the difference is negligible for modern devices.

---

Code Diff Analysis

File	Lines Added	Lines Removed	Status
Profile.tsx	26	16	Clean refactor
Settings.tsx	0	11	Dead code remaining
CalendarWidgetDemo.tsx	0	1482	Complete removal
index.tsx	0	6	Navigation cleanup
Home.tsx	0	8	Import cleanup
settings.local.json	2	1	Config change

---

Approval Status: Approved with Minor Changes Requested

This PR is functionally sound and ready to merge after addressing the following:

Required Changes (Before Merge):

1. Remove unused handleNavigateToCalendarWidgetDemo function in Settings.tsx
2. Fix hardcoded "utente" username to use AsyncStorage

Optional Improvements (Can be separate PR):

3. Add accessibility labels to avatar gradient
4. Use global RootStackParamList type instead of local definition
5. Add unit tests for avatar initial extraction

---

Final Notes

Great work on maintaining design consistency with the CLAUDE.md specifications! The gradient avatar is a nice visual upgrade that aligns with the app's minimalist design system. The removal of the 1500+ line demo file keeps the codebase lean.

Estimated merge impact: Low risk - changes are isolated to UI presentation layer with no business logic modifications.

---

Review completed by Claude Code Assistant
Following MyTaskly project conventions from CLAUDE.md