clangtidy warnings about narrowing in persistent classes

[brownd1978]

clangtidy gives warnings about narrowing when constructing persistent classes (ie in *DataProducts constructors). Those narrowings are conscious choices to reduce persistent payload. Can we turn off those warnings?

narrowing conversion from 'double' to 'float' [cppcoreguidelines-narrowing-conversions]

[rlcee]

clangy-tidy wants you to write myfloat = float(mydouble), so declaring the narrowing was intentional. If you don't like that, do you want the warning turned off globally, for the three *Products directories, or by file or instance (which would be very tedious)?

[brownd1978]

I don't see much value in this test in this *Products directory, if it could be turned off that would be good. We can also just update to make the explicit casts, its just tedious.