Skip to content

Secure docs workflow#26

Open
Yaswant Pradhan (yaswant) wants to merge 2 commits into
MetOffice:mainfrom
yaswant:secure_docs_workflow
Open

Secure docs workflow#26
Yaswant Pradhan (yaswant) wants to merge 2 commits into
MetOffice:mainfrom
yaswant:secure_docs_workflow

Conversation

@yaswant
Copy link
Copy Markdown
Collaborator

@yaswant Yaswant Pradhan (yaswant) commented May 22, 2026

PR Summary

Code Reviewer: James Bruten (@james-bruten-mo)

Tighten security around GitHub action for the documentation workflow as raised in #25.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)

trac.log

Not Required

Security Considerations

  • This change does not introduce security vulnerabilities
  • I have reviewed the code for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office GitHub Copilot Enterprise, GitHub Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label May 22, 2026
@yaswant Yaswant Pradhan (yaswant) added this to the Autumn 2026 milestone May 22, 2026
@yaswant Yaswant Pradhan (yaswant) linked an issue May 22, 2026 that may be closed by this pull request
7 tasks
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance security across workflows

2 participants