Can't apply themes persistently!

[Yaman-Harfoush]

Bug Description

Each time I apply a theme and close and reopen neovim, It tells me "Theme not found"!

For example:

Tell me please what should I do!

Operating System

Linux

[LmanTW]

How did you install the colorscheme? Are they installed through Themify, or did you use a separate package manager to manage the colorscheme packages?

[Yaman-Harfoush]

I already had themes installed, but they did not show up, so I reinstalled them using Themify.

[LmanTW]

I haven't visited this codebase in a while, so it might take me a while to debug this. Would you mind providing your Themify config?

[Yaman-Harfoush]

Sure, here:

require('themify').setup({
    async = true,
    activity = true,
  -- Your list of colorschemes.

  'folke/tokyonight.nvim',
  'sho-87/kanagawa-paper.nvim',
  'Mofiqul/adwaita.nvim',
  'catppuccin/nvim',
  'sainnhe/everforest',
  'projekt0n/github-nvim-theme',
  "ellisonleao/gruvbox.nvim",
  "rebelot/kanagawa.nvim",
  "tanvirtin/monokai.nvim",
  "loctvl842/monokai-pro.nvim",
  "EdenEast/nightfox.nvim",
  "navarasu/onedark.nvim",
  "rose-pine/neovim",
  'maxmx03/solarized.nvim',
  -- Built-in colorschemes are also supported.
  -- (Also works with any colorschemes that are installed via other plugin manager, just make sure the colorscheme is loaded before Themify is loaded.)
  'default'
})

[LmanTW]

Hm, I'm unable to reproduce it on my system. Maybe try disabling async?

[Yaman-Harfoush]

I already did, but had the same issue!
I also have themery on my system, if that's relevant!

[LmanTW]

Even with Themery installed on my system, I'm still unable to reproduce that error...
What Neovim version and linux distribution are you using?

[Yaman-Harfoush]

I'm using neovim 0.12.3
with arch linux!

[LmanTW]

Hmm, tried testing it on 0.12.3 but still can't reproduce it. As far as I know Arch shouldn't be the problem, so I'm kinda out of ideas...

[Yaman-Harfoush]

Could it be some line in my neovim configuration??

On my system neovim loads a theme installed via lazy.nvim to ~/.config/nvim/lua/plugins

And I don't have a vim.cmd.colorscheme (some theme) in my init.lua or lazy.lua!!

[LmanTW]

Do you mind sharing your entire Neovim config?

[Yaman-Harfoush]

Here:
https://github.com/Yaman-Harfoush/neovim-config

[LmanTW]

Oh I see the issue now, you're setting up Themify twice, first at plugins/themify.lua and then at config/lazy:

return {
  'lmantw/themify.nvim',

  lazy = false,
  priority = 999,

  config = {} -- This calls .setup(<config>) on the plugin
}

The best practice is to just do something like

return {
  'lmantw/themify.nvim',

  lazy = false,
  priority = 999,

  config = {
    async = false,
    activity = true,
    -- Your list of colorschemes.

    'folke/tokyonight.nvim',
    'sho-87/kanagawa-paper.nvim',
    'Mofiqul/adwaita.nvim',
    'catppuccin/nvim',
    'sainnhe/everforest',
    'projekt0n/github-nvim-theme',
    "ellisonleao/gruvbox.nvim",
    "rebelot/kanagawa.nvim",
    "tanvirtin/monokai.nvim",
    "loctvl842/monokai-pro.nvim",
    "EdenEast/nightfox.nvim",
    "navarasu/onedark.nvim",
    "rose-pine/neovim",
    'maxmx03/solarized.nvim',
    -- Built-in colorschemes are also supported.
    -- (Also works with any colorschemes that are installed via other plugin manager, just make sure the colorscheme is loaded before Themify is loaded.)
    'default'
  }
}

I think Themify used to not allow calling .setup twice, but for some reason the warning was removed.