could not paginate from apiLoader::retrieveAll

[lvrbacconnier]

$limit and $offset parameters are not used
https://github.com/LinkValue/MajoraFrameworkExtraBundle/blob/master/src/Majora/Framework/Loader/Bridge/Api/ApiLoaderTrait.php#L92

[lvrbacconnier]

I can't fix it now but maybe next week.

[Oliboy50]

indeed 👍

I think it could be done by using 2 if statements (like its already done in DoctrineLoader https://github.com/LinkValue/MajoraFrameworkExtraBundle/blob/master/src/Majora/Framework/Loader/Bridge/Doctrine/DoctrineLoaderTrait.php#L131-L136 )

But it will require to fetch the whole API results beforehand, then take only the splice of elements corresponding to those parameters... So the performance won't be improved by doing so... But since those parameters are here, you're right that they should be used, as expected :)

[lvrbacconnier]

the problem occurs when querying elasticsearch, which by default returns the 10 first results. We should then explicitely provide the size parameter.

[Oliboy50]

I see, I didn't know we could use the ApiLoader to hit Elasticsearch.

But Elasticsearch or a generic REST API should be used the same way, so you can't set the "size" parameter of Elasticsearch through ApiLoader::retrieveAll() method, because this parameter makes no sense for a generic REST API.

I think we have to create a specific ElasticsearchLoader, to handle your specific issue (and that would be a great step forward for this bundle).

But we still have to handle "limit" and "offset" parameters for the ApiLoader, because these are different issues.

[Oliboy50]

To work around your Elasticsearch issue until we have an ElasticsearchLoader, I think you could override the ApiLoader::retrieveAll() method and handle the "limit" and "offset" parameters the way you need (by adding size and from ES parameters to the api call).

But if you want to make an ElasticsearchLoader, it would be great :)