You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two residuals from #3118 (PR #3125 fixed the Android unsupported case), same false-assurance class — the UI asserts notification behavior the app doesn't deliver:
iOS Notifications / Critical-only toggles are write-only. The toggles in apps/mobile/src/screens/chat/components/SettingsSheet.tsx persist their state to AsyncStorage, but nothing consumes those keys — no code path filters or suppresses pushes based on them. Turning "Critical only" on changes nothing; turning Notifications off changes nothing.
The failed push-registration banner is dismissible per session. When registration status is failed, ApprovalGate shows a banner the user can dismiss; after dismissal the Notifications toggle (ON) is the only remaining signal, which is wrong — pushes are not arriving.
Proposed Fix
Either wire the toggles to real behavior (respect them at notification display/registration time, or send them server-side to filter dispatch) or remove/disable them until they do something.
Description
Two residuals from #3118 (PR #3125 fixed the Android
unsupportedcase), same false-assurance class — the UI asserts notification behavior the app doesn't deliver:apps/mobile/src/screens/chat/components/SettingsSheet.tsxpersist their state to AsyncStorage, but nothing consumes those keys — no code path filters or suppresses pushes based on them. Turning "Critical only" on changes nothing; turning Notifications off changes nothing.failedpush-registration banner is dismissible per session. When registration status isfailed, ApprovalGate shows a banner the user can dismiss; after dismissal the Notifications toggle (ON) is the only remaining signal, which is wrong — pushes are not arriving.Proposed Fix
failedstatus, give the Notifications row the same status-aware treatment fix(mobile): stop Settings asserting push works when registration is unsupported (#3118) #3125 added forunsupported(disabled/explanatory state), so the truth survives banner dismissal.Affected Files
apps/mobile/src/screens/chat/components/SettingsSheet.tsxapps/mobile/src/services/notifications.tsReported By
Review findings on #3125; follow-up to #3118