Description
ci.yml has required test-api, test-web, and test-agent jobs, but no job runs the apps/mobile vitest suite. All 28 mobile test files — including ~30 tests just added by the fixes for #3114, #3115, #3117, #3118, and #3119 — run local-only. A regression in mobile code merges green.
Flagged independently by the reviewers on three separate PRs (#3124, #3125, #3131).
Proposed Fix
Add a test-mobile job to .github/workflows/ci.yml mirroring test-web (pnpm install, pnpm --filter breeze-mobile test, plus tsc --noEmit in apps/mobile). Consider making it required once it proves stable.
Affected Files
Reported By
Review findings on #3124, #3125, #3131 (follow-up from the #3114–#3119 batch)
Description
ci.ymlhas requiredtest-api,test-web, andtest-agentjobs, but no job runs theapps/mobilevitest suite. All 28 mobile test files — including ~30 tests just added by the fixes for #3114, #3115, #3117, #3118, and #3119 — run local-only. A regression in mobile code merges green.Flagged independently by the reviewers on three separate PRs (#3124, #3125, #3131).
Proposed Fix
Add a
test-mobilejob to.github/workflows/ci.ymlmirroringtest-web(pnpm install,pnpm --filter breeze-mobile test, plustsc --noEmitinapps/mobile). Consider making it required once it proves stable.Affected Files
.github/workflows/ci.ymlReported By
Review findings on #3124, #3125, #3131 (follow-up from the #3114–#3119 batch)