From 7a0cbff7ed90fd600722749ad497fae7d14e7fe9 Mon Sep 17 00:00:00 2001 From: Varad Pimpalkhute Date: Fri, 3 Jul 2026 22:44:31 +0000 Subject: [PATCH] Tail-cancel on total remaining groups (unsubmitted + in flight), not just in-flight --- .../rollout/inference_rollout/inference_rollout_train.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/miles/rollout/inference_rollout/inference_rollout_train.py b/miles/rollout/inference_rollout/inference_rollout_train.py index acc4c03f2a..2e0e95403b 100644 --- a/miles/rollout/inference_rollout/inference_rollout_train.py +++ b/miles/rollout/inference_rollout/inference_rollout_train.py @@ -244,11 +244,11 @@ async def generate_rollout_async( data.append(group) pbar.update(args.n_samples_per_prompt) - # One pending task == one group, so len(pendings) is the live group count; - # with oversampling off, drop the slow tail once tail_cancel_groups remain. - if args.disable_oversampling and 0 < len(pendings) <= args.tail_cancel_groups: + groups_left = (target_data_size - submitted) + len(pendings) + if args.disable_oversampling and 0 < groups_left <= args.tail_cancel_groups: logger.info( - f"[rollout] tail-cancel: {len(pendings)} groups pending <= " + f"[rollout] tail-cancel: {groups_left} groups left " + f"({len(pendings)} in flight, {target_data_size - submitted} unsubmitted) <= " f"{args.tail_cancel_groups}; cutting tail with {len(data)}/{target_data_size} " f"groups collected" )