Skip to content

Test suite Windows compatibility #26

Description

@maurerv

After PR #25, pytme builds on Windows but does not pass all tests. A few temp files get created with mkstemp and then removed later without closing the file descriptor first, disallowed on Windows.

generate_tempfile_name in matching_utils and mkstemp calls in the tests need to be adapted accordingly. It is also worth checking np.memmap and h5py usage for the same pattern.

Would also be good to add a Windows runner to CI/CD.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions