After PR #25, pytme builds on Windows but does not pass all tests. A few temp files get created with mkstemp and then removed later without closing the file descriptor first, disallowed on Windows.
generate_tempfile_name in matching_utils and mkstemp calls in the tests need to be adapted accordingly. It is also worth checking np.memmap and h5py usage for the same pattern.
Would also be good to add a Windows runner to CI/CD.
After PR #25, pytme builds on Windows but does not pass all tests. A few temp files get created with
mkstempand then removed later without closing the file descriptor first, disallowed on Windows.generate_tempfile_nameinmatching_utilsandmkstempcalls in the tests need to be adapted accordingly. It is also worth checkingnp.memmapandh5pyusage for the same pattern.Would also be good to add a Windows runner to CI/CD.