TECH: FocusLogger Refactoring

[EvoJocys]

Refactoring backlog for FocusLogger

Discover code-quality improvements this repository would benefit from (renames, extract method, dead-code removal, duplication consolidation) and propose the next one as a concrete child work item.

Use the work-item-refactoring skill.

[EvoJocys]

[AI Review] · Story Points: 2 · Difficulty: None (0) · Impact: Medium (2) · AI Work: 85% · Human Work: 15%

Review Summary

Skill Matrix: C#, WPF / .NET 8, Refactoring & dead-code analysis, Roslyn / static analysis (CA2213), Git / PR workflow

Story Points (reasons):
- Work type: Deletion/removal — baseline 1–3; this is purely mechanical dead-code elimination with no design decisions or call-site updates required.
- Calibration match: Closest to '2' (few hours) — three targeted changes (delete one file, remove two lines), plus a verification pass for hidden references (reflection, XAML keys, generated code) and a clean-build confirmation.
- Codebase context: AI assessment already confirmed via Qdrant searches that DataItemType.cs has zero callers, HMan has no XAML binding, and the assembly local is never consumed — scope is fully understood and bounded to two files.
- No adjustment — AC requires only a clean build and no functional change; no staged rollout, cross-team coordination, or special requirements mentioned.

Split recommendation: No

Notes: Qdrant searches confirmed all seven issues identified in the Summary against the live source files. Key findings:

1. **`DataItemType.cs`** — confirmed: the file contains only `public enum DataItemType { None = 0, }`. No other file in the repository references this type. Safe to delete.

2. **`MainWindow.xaml.cs`** — confirmed: `var assembly = Assembly.GetExecutingAssembly();` is assigned but the subsequent `AssemblyInfo()` constructor takes no parameters and `assembly` is never passed or read. The public field `public InfoControl HMan;` is never assigned or read; the XAML `MainWindow.xaml` binds the control as `x:Name="InfoPanel"`, confirming `HMan` is dead code.

3. **`DataItem.NonPath` / `_IsError`** — confirmed: the property IS actively used in `DataListControl` (set in `UpdateFromProcess` for both the System-Idle-Process path and exception paths; read in the formatting converter to dim the `ProcessPathColumn`). This is a rename task (items 4), not a dead-code removal.

4. **`DataItem.StatusCode`** — confirmed: the `MessageBoxImage StatusCode` property exists in `DataItem.cs` but is never read in the formatting converter or any other code path found. Dead-code / layer-leak candidate (item 5).

5. **`AddLock`** — confirmed: `object AddLock = new object();` is non-private, non-readonly, used as a `lock` monitor inside `UpdateInfo()`. Should be `private readonly object _addLock = new object();`.

6. **`UpdateInfo()` duplication** — confirmed: the active-window and foreground-window polling blocks in `DataListControl.UpdateInfo()` are structurally identical (get handle → build DataItem → compare → UpdateFromProcess → BeginInvoke to prepend). Candidate for extract-method refactoring.

**Recommended next child work item** (per the Summary): a single PR that removes the three zero-risk dead-code items — delete `DataItemType.cs`, remove the `HMan` field, and remove the unused `assembly` local. This is a mechanical, compiler-verifiable change with no call-site impact. No clarifying questions needed; all context is fully available in the codebase and `.ai/instructions.md` constraints are straightforward. ImpactScore is 2 because these are internal code hygiene improvements with no direct user-facing effect but genuine maintainability benefit.

Clarifying Questions from Developer:
None

Proposed Solution: Implement the first (safest) child refactoring PR containing exactly three changes:

1. **Delete `FocusLogger/Common/DataItemType.cs`** — the entire file. The enum `DataItemType` has no callers anywhere in the project. No other files need updating.

2. **`FocusLogger/MainWindow.xaml.cs` — remove `HMan` field**: delete the line `public InfoControl HMan;`. The XAML-bound control is `InfoPanel`; `HMan` is unused and unassigned.

3. **`FocusLogger/MainWindow.xaml.cs` — remove unused local in `LoadHelpAndInfo()`**: delete `var assembly = Assembly.GetExecutingAssembly();`. The `AssemblyInfo()` constructor and subsequent `GetTitle` call do not consume it.

All three changes are compiler-verifiable: the solution must build cleanly with zero new warnings after the removals. No renames, no call-site updates, no XAML changes required. Conformance with `.ai/instructions.md`: changes are localized, no validated workarounds are touched, no deprecated APIs introduced.

Subsequent child items (lower priority, separate PRs):
- Item 4: Rename `DataItem.NonPath` → `IsPathError` / `_IsError` → `_isPathError` (update 3 call sites in `DataListControl`).
- Item 5: Remove or replace `DataItem.StatusCode` (`MessageBoxImage` layer-leak).
- Item 6: Make `DataListControl.AddLock` → `private readonly object _addLock`.
- Item 7: Extract `TrackWindowChange()` helper from `UpdateInfo()` to eliminate duplication.

Related Items:
FocusLogger/Common/DataItemType.cs
FocusLogger/Common/DataItem.cs
FocusLogger/MainWindow.xaml.cs
FocusLogger/Controls/DataListControl.xaml.cs
FocusLogger/MainWindow.xaml
FocusLogger/Common/NativeMethods.cs
.ai/instructions.md

Solver Agent Prompt: Use to instruct other AI agents (e.g., CoPilot, CLINE...) to implement the solution.

**Work Item to Address:**
Title: TECH: FocusLogger Refactoring — Dead-Code Removal (Child Item #1)
Description:

The FocusLogger codebase has been analysed for code-quality issues. The safest and highest-priority batch is the removal of three dead-code items that have zero call-site impact and can be verified purely by a clean compiler build.
The three items are:


Delete FocusLogger/Common/DataItemType.cs — This file contains only public enum DataItemType { None = 0, }. No code anywhere in the repository references this enum. The entire file should be deleted.


Remove public InfoControl HMan; from FocusLogger/MainWindow.xaml.cs — This public field is never assigned and never read. The XAML file (FocusLogger/MainWindow.xaml) registers the InfoControl as x:Name="InfoPanel", confirming HMan has no XAML counterpart and is dead code.


Remove var assembly = Assembly.GetExecutingAssembly(); from MainWindow.LoadHelpAndInfo() — This local variable is assigned but never consumed; the AssemblyInfo() constructor and the subsequent GetTitle call do not use it.


Acceptance Criteria:

FocusLogger/Common/DataItemType.cs no longer exists in the repository.
FocusLogger/MainWindow.xaml.cs no longer contains the field public InfoControl HMan;.
FocusLogger/MainWindow.xaml.cs — LoadHelpAndInfo() no longer contains var assembly = Assembly.GetExecutingAssembly();.
The solution builds with zero errors and zero new warnings after the changes.
No functional behaviour is altered.
Changes conform to .ai/instructions.md: localized/targeted only; no validated code or workarounds removed; no deprecated APIs introduced.

Key Comments:

None.
Linked Work Items:

None.
Potentially Relevant Files/Artifacts:

FocusLogger/Common/DataItemType.cs — file to be deleted
FocusLogger/MainWindow.xaml.cs — remove HMan field and unused assembly local
FocusLogger/MainWindow.xaml — confirms HMan has no XAML binding (InfoControl is InfoPanel)
FocusLogger/Common/DataItem.cs — context only; not modified in this item
FocusLogger/Controls/DataListControl.xaml.cs — context only; not modified in this item
FocusLogger/Common/NativeMethods.cs — context only; not modified in this item
.ai/instructions.md — project AI/refactoring constraints to respect

Please analyse this work item and the provided context. Verify there are no hidden references to the three dead-code items (e.g., reflection, XAML resource keys, generated code) before removing them. Then apply the deletions and confirm the solution compiles cleanly.

Your working directory will be the root of the repository.