From 13d1f6ef56e156225ad74144319c7e5c58918634 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gautier=20Ben=20A=C3=AFm?= Date: Thu, 30 Apr 2026 14:35:03 +0200 Subject: [PATCH] fix(create-module): ensure icons are created with the right name when hyphens are used --- ...ODULE_helloCard.png => $NAMESPACE_helloCard.png} | Bin ...ULE_helloWorld.png => $NAMESPACE_helloWorld.png} | Bin ...ix_component.png => $NAMESPACEmix_component.png} | Bin .../tests/create-templatesSet-project.test.js | 6 +++--- 4 files changed, 3 insertions(+), 3 deletions(-) rename javascript-create-module/templates/hello-world/settings/content-types-icons/{$MODULE_helloCard.png => $NAMESPACE_helloCard.png} (100%) rename javascript-create-module/templates/hello-world/settings/content-types-icons/{$MODULE_helloWorld.png => $NAMESPACE_helloWorld.png} (100%) rename javascript-create-module/templates/module/settings/content-types-icons/{$MODULEmix_component.png => $NAMESPACEmix_component.png} (100%) diff --git a/javascript-create-module/templates/hello-world/settings/content-types-icons/$MODULE_helloCard.png b/javascript-create-module/templates/hello-world/settings/content-types-icons/$NAMESPACE_helloCard.png similarity index 100% rename from javascript-create-module/templates/hello-world/settings/content-types-icons/$MODULE_helloCard.png rename to javascript-create-module/templates/hello-world/settings/content-types-icons/$NAMESPACE_helloCard.png diff --git a/javascript-create-module/templates/hello-world/settings/content-types-icons/$MODULE_helloWorld.png b/javascript-create-module/templates/hello-world/settings/content-types-icons/$NAMESPACE_helloWorld.png similarity index 100% rename from javascript-create-module/templates/hello-world/settings/content-types-icons/$MODULE_helloWorld.png rename to javascript-create-module/templates/hello-world/settings/content-types-icons/$NAMESPACE_helloWorld.png diff --git a/javascript-create-module/templates/module/settings/content-types-icons/$MODULEmix_component.png b/javascript-create-module/templates/module/settings/content-types-icons/$NAMESPACEmix_component.png similarity index 100% rename from javascript-create-module/templates/module/settings/content-types-icons/$MODULEmix_component.png rename to javascript-create-module/templates/module/settings/content-types-icons/$NAMESPACEmix_component.png diff --git a/javascript-create-module/tests/create-templatesSet-project.test.js b/javascript-create-module/tests/create-templatesSet-project.test.js index d27ec419..fb660de9 100644 --- a/javascript-create-module/tests/create-templatesSet-project.test.js +++ b/javascript-create-module/tests/create-templatesSet-project.test.js @@ -74,9 +74,9 @@ test("Project creation", async () => { // Make sure the renaming with MODULE_NAME is correct "settings/resources/project-name.properties", "settings/resources/project-name_fr.properties", - "settings/content-types-icons/project-namemix_component.png", - "settings/content-types-icons/project-name_helloWorld.png", - "settings/content-types-icons/project-name_helloCard.png", + "settings/content-types-icons/projectnamemix_component.png", + "settings/content-types-icons/projectname_helloWorld.png", + "settings/content-types-icons/projectname_helloCard.png", // Check other setting files "settings/template-thumbnail.png", "settings/locales/en.json",