Support ITensorBase v0.13#154
Merged
Merged
Conversation
## Summary Builds ITensorNetworksNext against ITensorBase v0.13 (ITensor/ITensorBase.jl#222), which reworks `NamedTensorOperator` around an output/input name pairing. Renames the `domainnames` accessor to `inputnames` in the belief-propagation apply path. The Ising-network generator inserted each bond matrix with `apply` on an operator whose shared leg was its output. The reworked `apply` preserves a state's names and only contracts an operator's input, so it now rejects that usage. The old `apply` had degraded to a plain contraction in that case anyway, so this replaces it with the direct named contraction it was really doing, leaving the generated network and the Ising free-energy checks unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 84.89% 84.89%
=======================================
Files 15 15
Lines 662 662
=======================================
Hits 562 562
Misses 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds ITensorNetworksNext against ITensorBase v0.13 (ITensor/ITensorBase.jl#222), which reworks
NamedTensorOperatoraround an output/input name pairing. Renames thedomainnamesaccessor toinputnamesin the belief-propagation apply path.The Ising-network generator inserted each bond matrix with
applyon an operator whose shared leg was its output. The reworkedapplypreserves a state's names and only contracts an operator's input, so it now rejects that usage. The oldapplyhad degraded to a plain contraction in that case anyway, so this replaces it with the direct named contraction it was really doing, leaving the generated network and the Ising free-energy checks unchanged.