Give AbstractNamedTensor a generic dimnametype default#225
Merged
Conversation
`dimnametype` fell back to `Any` for any `AbstractNamedTensor` subtype that did not define its own method, so `NamedTensorOperator` reported `Any` even though it carries its dimname type as a parameter. That broke factorizations that mint a fresh bond name on an operator (`qr_compact`, `svd`, and friends), which minted the new name from `Any`.
Since `AbstractNamedTensor{DimName}` already carries the dimname type, the default reads it from the supertype, covering every subtype uniformly and subsuming the per-type methods on `NamedTensor` and `SymbolicNamedTensor`, which are removed. The `Any` fallback remains for a fully unparameterized `AbstractNamedTensor`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 77.23% 77.21% -0.02%
==========================================
Files 29 29
Lines 1713 1712 -1
==========================================
- Hits 1323 1322 -1
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
enabled auto-merge (squash)
July 21, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dimnametypefell back toAnyfor anyAbstractNamedTensorsubtype that did not define its own method, soNamedTensorOperatorreportedAnyeven though it carries its dimname type as a parameter. That broke factorizations that mint a fresh bond name on an operator (qr_compact,svd, and friends), which minted the new name fromAny.Since
AbstractNamedTensor{DimName}already carries the dimname type, the default reads it from the supertype, covering every subtype uniformly and subsuming the per-type methods onNamedTensorandSymbolicNamedTensor, which are removed. TheAnyfallback remains for a fully unparameterizedAbstractNamedTensor.