fence_type=chain_link not included in fence material quest?

[tangledrockets]

How to Reproduce
Select What material is this fence made of?
Look for the chain link option to tag a chain link fence.

Expected Behavior
Alongside other fence types/materials, the option to select chain link should be visible.

Does it happen in normal StreetComplete?
I'm fairly certain this quest is SCEE only

Versions affected
v63.0

I'm not sure this classifies as a bug, but based on "unexpected behaviour" I would consider it as such.

Chain link fences are very common, very standardised and very identifiable. Based on the usually intuitive approach to quests in SC, when I selected the quest I expected to see the option for chain link fence presented. (As I was standing in front of a chain link fence at the time it was particularly relevant)

Especially given the "Wire" option is available, which tags both fence_type and material, I would expect chain link to be available also.

Chain link is the most common fence_type:
https://taginfo.openstreetmap.org/keys/fence_type#values

with nearly 20%, compared to nearly 10% for wire.

Reading the discussion in #872 , where chain link is mentioned, I would have expected it to be included. I could find no reason presented to exclude it.

Given that it is so common, I think leaving it off the list could lead to confusion and/ or mistagging - I myself was close to tagging wire as the closest option before confirming that there was followup option to specify chain link.

Is there a reason chain link was not included?

[mcliquid]

It’s been a few weeks now, but I can’t remember a specific reason. I probably just forgot about it at the time. The focus was more on the material, not on the fence type.

[pkoby]

It looks like the quest adds fence_type=wire material=metal when you select "wire". But chain-link fence is a type of wire and should be fence_type=chain_link. Maybe material and fence_type should be two different quests? And the material quest should only have "metal", not "wire".

To add to this: TagInfo shows 10.23% tagged with fence_type, 2.63% with material. Does that mean that material is a more useful quest? Or is fence_type considered more useful by the community, so should have a quest?

[mcliquid]

I’ve gone through all the comments in that issue again, as well as in the pull request.
Most important ones:

• Quest suggestion: What is this fence made of? #872 (comment)
• https://github.com/Helium314/SCEE/pull/883/changes#r2819357464

The quest was scoped as a material=* question for barrier=fence, not as a general fence_type quest, and the original proposal only listed material answers like wood, concrete, metal, stone, plastic, and brick.
In the PR, the filter was implemented as barrier = fence plus !material, with an extra exclusion for fence_type != wire.
wire was excluded because it effectively implies material=metal, so asking again would be redundant.
I did not add other fence_type values such as chain_link, because that would mix two different tagging concepts; those are better handled by a separate fence-type quest rather than by this material quest.

In my view, this issue should state that we should remove the fence_type=wire attribute entirely from the FenceMaterial quest, and that a separate quest is needed for FenceType.

[tangledrockets]

I would agree, tidiest solution would likely be to create 2 separate quests. Mixing tags can get complicated quickly.

The other option would be to incorporate other common fence_types into the quest, but as discussed in the original thread, fence_type is a bit messy and overlaps in places with material, making clean implementation difficult.

I forgot to add to the initial report that SC/SCEE is a fantastic creation, it's what got me into osm to begin with. Thanks for all the work you do to maintain it!

[mnalis]

In my view, this issue should state that we should remove the fence_type=wire attribute entirely from the FenceMaterial quest, and that a separate quest is needed for FenceType.

yeah, that would probably be the cleanest solution in the end... just have existing quest ask about and tag material=*, and then a new quest might be implemented for fence_type=* (if that is deemed useful enough, i.e. not more confusing then helping)

[andrewharvey]

I started seeing the fence material quest, but I found the photo for wire misleading.

I would assume "metal" would be for fences that are rigid, but "wire" for fences like chicken wire fences https://en.wikipedia.org/wiki/Chicken_wire or bendable wire fences that are more flexible like these.

The photo for the wire fence looks the same as the metal fence to me, so I'd suggest using one of these two photos instead.

[Helium314]

According to the wiki there is a wide variety (see the images). Maybe we could show both photos to capture that.
If we switch to your photos, users will likely not tag the other variants as wire.