From 6220c43e50176a290bdf5a0326f048d8743e7d86 Mon Sep 17 00:00:00 2001 From: Joshua Gilman Date: Sun, 28 Dec 2025 21:50:00 -0800 Subject: [PATCH] fix: correct talos imager flags for embedded config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Change --output-path to use default /out directory - Fix --embedded-config-path flag format (use = instead of space) - Remove unnecessary mkdir for output subdirectory - Update output path to match imager's default location 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- images/hooks/talos-embed-config.sh | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/images/hooks/talos-embed-config.sh b/images/hooks/talos-embed-config.sh index b4bb186..9b8673c 100755 --- a/images/hooks/talos-embed-config.sh +++ b/images/hooks/talos-embed-config.sh @@ -128,28 +128,25 @@ embed_config() { echo "Creating ISO with embedded configuration..." echo " Talos version: ${talos_version}" - # Create output directory for imager - mkdir -p "${WORK_DIR}/out" - # Copy config to a location the imager can access cp "${config_file}" "${WORK_DIR}/machine.yaml" # Run the imager to create a new ISO with embedded config # The imager creates a fresh ISO from scratch - it doesn't modify the downloaded ISO - docker run --rm \ - -v "${WORK_DIR}:/work" \ + # Mount work dir to /out (imager's default output directory) + docker run --rm -t \ + -v "${WORK_DIR}:/out" \ "ghcr.io/siderolabs/imager:${talos_version}" \ iso \ --arch amd64 \ - --output-path /work/out \ - --embedded-config-path /work/machine.yaml + --embedded-config-path=/out/machine.yaml - # Find the generated ISO - local output_iso="${WORK_DIR}/out/metal-amd64.iso" + # Find the generated ISO (imager outputs to /out/metal-amd64.iso) + local output_iso="${WORK_DIR}/metal-amd64.iso" if [[ ! -f "${output_iso}" ]]; then echo "ERROR: Output ISO not found: ${output_iso}" >&2 - ls -la "${WORK_DIR}/out/" >&2 + ls -la "${WORK_DIR}/" >&2 exit 1 fi