[Improvement]: getDefineStringArray does not sanitize array input

[CharGoldenYT]

when using polymod.util.DefineUtil.getDefineStringArray, if (for some reason) the define input is ['array', 'items']

you get [['array', 'items']] when parsed

a quick edit to the function like as shown below, could remedy this (small change is why its an issue not a pr)

public static function getDefineStringArrayRaw(key:String, ?defaultValue:Array<String>):Array<String> {
		if (defaultValue == null)
			defaultValue = new Array<String>();
		var value = Context.definedValue(key);
		if (value != null)
		{
			var str:String = cast value;
			value = str.replace("[", "").replace("]", "");
		}
		return value == null ? defaultValue : value.split(',');
	}

of course this does not account for strings inside potentially being the result "'string'" (and vice-versa) and requires using StringTools;

[CharGoldenYT]

but then it breaks arrays in arrays doesn't it.

hmm.

[EliteMasterEric]

getDefineStringArray() expects to return an array of String values. It would probably accept both "array, items" and ['array', 'items'] as input, but not [['array']].

[yeymir580-del]

public static function getDefineStringArrayRaw(key:String, ?defaultValue:Array):Array {
if (defaultValue == null)
defaultValue = new Array();
var value = Context.definedValue(key);
if (value != null)
{
var str:String = cast value;
value = str.replace("[", "").replace("]", "");
}
return value == null ? defaultValue : value.split(',');
}