#6280 Improve validation of OpenPGP revocation signatures for contact keys - #6281
Merged
sosnovsky merged 3 commits intoAug 25, 2026
Merged
Conversation
martgil
changed the title
sosnovsky
reviewed
Aug 25, 2026
Comment on lines
+227
to
+234
| let records: StoredRevocation[] = []; | ||
| { | ||
| const tx = db.transaction(['revocations'], 'readonly'); | ||
| records = await new Promise((resolve, reject) => { | ||
| const search = tx.objectStore('revocations').getAll(); | ||
| ContactStore.setReqPipe(search, resolve, reject); | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
let's simplify it and just use const instead of let for records:
const tx = db.transaction(['revocations'], 'readonly');
const records = await new Promise<StoredRevocation[]>((resolve, reject) => {
const search = tx.objectStore('revocations').getAll();
ContactStore.setReqPipe(search, resolve, reject);
});
Collaborator
Author
There was a problem hiding this comment.
Thanks @sosnovsky - I'll check it out and push the necessary changes.
Comment on lines
+241
to
+243
| if (!(await KeyUtil.parse(record.armoredKey)).revoked) { | ||
| bogusFingerprints.push(record.fingerprint); | ||
| } |
Collaborator
There was a problem hiding this comment.
I think here we should also check that parsed key is pgp key and compare it's fingerprint, like this:
const key = await KeyUtil.parse(record.armoredKey);
if (key.family === 'openpgp' && (key.id !== record.fingerprint || !key.revoked)) {
bogusFingerprints.push(record.fingerprint);
}
Collaborator
Author
There was a problem hiding this comment.
I agree on this one. I'll update it accordingly. Thank you for your feedback, Roma.
Collaborator
Author
|
Hi @sosnovsky - Just requesting for another review. It looks good though overall but feel free to re-check. Thank you! |
sosnovsky
deleted the
issue-6280-improve-validation-of-opengpg-revocation-signatures
branch
August 25, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves validation of OpenPGP revocation signatures for contact keys.
Closes #6280
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):