feat(xlsx): support Excel cell checkboxes in conversion#90
Draft
juliusknorr wants to merge 1 commit into
Draft
Conversation
Resolve the featurePropertyBag xfComplement chain into a per-xf checkbox flag on read, carry it through Editor.bin (c_oSerXfsTypes::CellControl), and regenerate the canonical featurePropertyBag part plus xf extLst on write so checkbox cells round-trip xlsx <-> bin. AI-assistant: Claude Code 2.1.163 (claude-opus-4-8) Signed-off-by: Julius Knorr <jus@bitgrid.net>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds xlsx ↔ Editor.bin support for Excel's modern cell checkbox feature.
xl/featurePropertyBag/featurePropertyBag.xmland resolve the per-xfxfComplementchain into a boolean checkbox flag on the cell xf.c_oSerXfsTypes::CellControl).extLst(cellXfs and cellStyleXfs).Verified by round-tripping a checkbox file (D8) xlsx → bin → xlsx: the part, relationship, content-type and xf extLst all survive (confirmed absent on the pre-change build).
Note: independent/alternative implementation; an existing
feature/checkboxbranch also implements this (with ODF support). Opened for comparison. xlsb path intentionally out of scope.