Replace react-native-piratechain with react-native-pirate-wallet#6021
Draft
j0ntz wants to merge 1 commit into
Draft
Replace react-native-piratechain with react-native-pirate-wallet#6021j0ntz wants to merge 1 commit into
j0ntz wants to merge 1 commit into
Conversation
The Pirate Chain team's orchard upgrade ships a unified SDK whose react-native binding (react-native-pirate-wallet) replaces the react-native-piratechain wrapper Edge wrote. The reimplemented piratechain plugin in edge-currency-accountbased consumes the new module through the same makePiratechainIo nativeIo bridge, so no GUI code changes are needed beyond the dependency swap. The package is not yet published to npm (it only exists as a zip asset on PirateNetwork GitHub releases), so the dependency points at a vendored sibling checkout (file:../react-native-pirate-wallet) staged from the official v1.1.4 release artifacts. Swap to a hosted tgz or npm version once a packaging decision is made.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-currency-accountbased#1055
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana: https://app.asana.com/0/1215088146871429/1214721783909451
Draft until a packaging decision is made for
react-native-pirate-wallet.Swaps
react-native-piratechainforreact-native-pirate-wallet, the Pirate Chain team's react-native binding from their unified orchard-upgrade SDK (Pirate-Unified-Light-Wallet). The reimplemented piratechain plugin (EdgeApp/edge-currency-accountbased#1055) consumes it through the existingmakePiratechainIonativeIo bridge, so the dependency swap is the only GUI change. iOS links the vendoredPirateWalletNative.xcframeworkvia autolinking; Android autolinks the bundled jniLibs.The package is not published to npm — it only exists as a 473 MB zip asset on the PirateNetwork v1.1.4 GitHub release (prebuilt xcframework + jniLibs, staged by their
prepare-react-native-plugin.sh). For development this PR points the dependency at a vendored sibling checkout (file:../react-native-pirate-wallet) extracted from that release artifact. Before this can land, the package needs a real home, e.g.:@zano-project/zano-utils-jspattern), possibly under the existingEdgeApp/react-native-piratechainrepo, or