Nineteen architecture rules select a package layout that no longer exists

[ExtraToast]

ArchitecturePackages.kt declares 51 package constants. 39 of them name a package no class resides in, and 19 of those are still used by rules — so those rules select nothing and pass without checking anything.

Measured against origin/main by expanding each constant's ArchUnit pattern (.. = any depth, * = one segment) and matching it against the 109 packages that actually hold Kotlin under services/api/src/main/kotlin.

The dead constants that rules still reference, with how many rule files use each:

constant	rule files	refs
WEB	4	17
DTO	4	13
PERSISTENCE	4	12
APPLICATION	2	9
JOB	1	5
QUERY	1	4
DOMAIN, LISTENER	1 each	3
DOMAIN_SERVICE, REPOSITORY	2 each	5, 3
APPLICATION_VALIDATION, EVENT, FACTORY, DOMAIN_MODEL, SPECIFICATION, DOMAIN_WEB, DOMAIN_APPLICATION, DOMAIN_EVENT, DOMAIN_SURVEY	1 each	2 each

They are all shapes the flattening in architecture ADR-003 removed: a central web/application/domain/persistence layer, a domain.<feature> prefix, and the platform.integration..adapter/..application tree. A module now holds api, domain, persistence and web directly under its own name.

Why this matters beyond tidiness

#1157 found three such constants and #1158 fixes them. This is the same defect at eleven times the size, and it is invisible: a vacuous ArchUnit rule is green, so the suite reports these rules as passing. Nobody learns the rule stopped applying — they learn it when something the rule forbade turns up in review, or does not.

The twenty remaining dead constants are referenced by nothing and are clutter rather than a live problem.

Suggested order

Rule by rule, not constant by constant. For each rule, work out what it was written to check, decide whether the flattening made it redundant, and either express it against today's topology or delete it with the reason. #1158 does exactly this for its three and is worth reading first — one of its three turned out to be genuinely redundant and was deleted rather than repointed.

Worth considering as part of the fix: something that fails when a constant matches nothing. A rule that selects an empty set is almost always a mistake, and ArchUnit's allowEmptyShould(false) says so directly.

Acceptance criteria

• No rule selects classes through a constant that matches nothing
• Each affected rule is either expressed against today's packages or deleted with its reason recorded
• Unused dead constants are gone
• A constant that matches no class cannot pass silently

[ExtraToast]

Correction to this issue's own measurement, from implementing it.

My table was built by expanding each glob with a hand-written regex, and that regex was wrong: ArchUnit's .. matches zero packages as well as many, so net.blueshell.api..web.. does match net.blueshell.api.user.web. My conversion also swallowed the separating dot, so patterns that should have matched read as dead.

Measured with ArchUnit's own matcher against the imported classes, WEB (267 classes), DOMAIN (492), PERSISTENCE (132) and DTO (3) are live, not dead — and those four carried most of the rule-file counts in the table above. The real figure is 32 dead globs, 13 of them read by rules, not 39 and 19.

The defect is real and the fix is the same shape; only its size was overstated. #1165 records the corrected numbers.

Worth keeping from this: DTO matched three platform error DTOs while every module's web/dto folder was empty — so a constant can still match and yet no longer mean what its readers assume. No automated check catches that; it is why DTO and DOMAIN were deleted despite matching.