Problem Statement
Two rules this repository wrote down for itself are not kept by the code, and in both cases the code reads as though they are.
docs/adr/frontend/ADR-001-domain-feature-architecture.md says pages/** and components/** may not import @/services/api, and that new feature work goes to domains/<domain> first. The three bulk dialogs under components/common/modals/bulk/ import the generated client directly, and src/utils/contributionEmail.ts holds roughly 230 lines of contribution domain rules outside any domain.
@Positive on the elements of a List<Long> request field does nothing. Kotlin emits JVM type annotations only under -Xemit-jvm-type-annotations, which no Gradle module here sets, so Hibernate Validator has nothing to act on. Several endpoints advertise a constraint they do not have. Confirmed with javap on SendPaymentEmailsRequest.
A rule that only the documentation keeps is worse than no rule: it is read as enforced by everybody after the person who wrote it.
Order
The two slices are independent. Either can land first.
Slices
Problem Statement
Two rules this repository wrote down for itself are not kept by the code, and in both cases the code reads as though they are.
docs/adr/frontend/ADR-001-domain-feature-architecture.mdsayspages/**andcomponents/**may not import@/services/api, and that new feature work goes todomains/<domain>first. The three bulk dialogs undercomponents/common/modals/bulk/import the generated client directly, andsrc/utils/contributionEmail.tsholds roughly 230 lines of contribution domain rules outside any domain.@Positiveon the elements of aList<Long>request field does nothing. Kotlin emits JVM type annotations only under-Xemit-jvm-type-annotations, which no Gradle module here sets, so Hibernate Validator has nothing to act on. Several endpoints advertise a constraint they do not have. Confirmed withjavaponSendPaymentEmailsRequest.A rule that only the documentation keeps is worse than no rule: it is read as enforced by everybody after the person who wrote it.
Order
The two slices are independent. Either can land first.
Slices