Follow-up to #1067, which moved the three loader-invoking esports integration tests onto a fixture seed.
What is left
GameIT, EsportsControllerIT, EsportsRefusalIT, SeasonGameIT and TeamNameConsentIT do not invoke the seed loader themselves. They read the game rows Flyway wrote at context start, which the clean-up between tests restores, and they assert on them directly — eight games, VALORANT first, "CS:GO" as a name.
So a game added to or removed from games.csv fails a test that has nothing to say about games, which is the same complaint #1067 fixed for the loader tests.
Why it was not done there
Fixtures reach these tests only by changing what the application seeds under the test profile — EsportsSeed.files would have to be profile-dependent — or by rewriting each test to create the Game rows it needs. Either is a larger change than the data correction that prompted #1067, and neither is needed to keep that one green.
Worth deciding first
Whether "every game is answered for, in the order they are shown" means anything once the games under test are invented. If the point of that test is the shipped set, it may belong with ShippedArtRealSeedTest as a guard on the real data rather than converted.
Follow-up to #1067, which moved the three loader-invoking esports integration tests onto a fixture seed.
What is left
GameIT,EsportsControllerIT,EsportsRefusalIT,SeasonGameITandTeamNameConsentITdo not invoke the seed loader themselves. They read thegamerows Flyway wrote at context start, which the clean-up between tests restores, and they assert on them directly — eight games,VALORANTfirst,"CS:GO"as a name.So a game added to or removed from
games.csvfails a test that has nothing to say about games, which is the same complaint #1067 fixed for the loader tests.Why it was not done there
Fixtures reach these tests only by changing what the application seeds under the test profile —
EsportsSeed.fileswould have to be profile-dependent — or by rewriting each test to create theGamerows it needs. Either is a larger change than the data correction that prompted #1067, and neither is needed to keep that one green.Worth deciding first
Whether "every game is answered for, in the order they are shown" means anything once the games under test are invented. If the point of that test is the shipped set, it may belong with
ShippedArtRealSeedTestas a guard on the real data rather than converted.