Random crash on open

[CocoBox84]

---

Discord Messenger fatal error! (Press CTRL-C to copy!)

Oops! DiscordMessenger just crashed!

Thread ID: 824
Exception Code: C0000005
Exception Address: 004a723a
Exception Parameters: 00000000 00000000 (https://www.youtube.com/watch?v=bLHL75H_VEM)
EIP=004A723A EFLAGS=00010202
EAX=00000000 EBX=00228CB4 ECX=0000000A EDX=0000000A
ESI=00000243 EDI=0000000A ESP=00228C34 EBP=00228CDC

Send this to iProgramInCpp right away!
Hint: Press Ctrl-C to copy the whole message box's text.

Windows Version 5.0.2195 [NT] (Service Pack 4)
DiscordMessenger V1.10 MinGW Unicode Release x86

Here is a stack trace:

• [F:002284b0] 00478f81 [DiscordMessenger.exe(00400000)+00078f81]
• [F:00228550] 7c51bdbd [KERNEL32.DLL(7c4e0000)+0003bdbd]
• [F:00228858] 7c519c2c [KERNEL32.DLL(7c4e0000)+00039c2c]

And here's a stack dump.
002284b0: 50 85 22 00 81 8f 47 00 ac c3 70 00 38 03 00 00
002284c0: 05 00 00 c0 3a 72 4a 00 00 00 00 00 00 00 00 00
002284d0: 7c c3 70 00 3a 72 4a 00 02 02 01 00 00 00 00 00
002284e0: b4 8c 22 00 0a 00 00 00 0a 00 00 00 43 02 00 00
002284f0: 0a 00 00 00 34 8c 22 00 dc 8c 22 00 00 00 00 00
00228500: 00 00 00 00 00 00 00 00 00 00 00 00 dc 8c 22 00
00228510: 3a 72 4a 00 3a 72 4a 00 02 02 01 00 00 00 00 00
00228520: b4 8c 22 00 0a 00 00 00 0a 00 00 00 43 02 00 00
Enjoy debugging this thing!

OK

[KontrollFreek]

I wasn't able to replicate this error on a copy of Windows 2000 SP4 running in QEMU. What hardware or setup are you using? And would you be able to use the MinGW symbols version instead?

[iProgramMC]

@KontrollFreek The MinGW symbols builds do not actually show a different stack trace. They're there for transparency. I could just... not provide these builds and keep them on my hard drive, but they're probably useful to somebody.

The symbols builds are literally the exact same code and data, in the exact same order, as in the normal version. I just run strip DiscordMessenger-MinGW-Symbols.exe, and out pops the binary that people usually download.

[iProgramMC]

@CocoBox84 The stack trace seems incomplete, are you sure you copied the whole thing?

Also, are you able to tell me the system specifications (specifically, memory + page file size) of your machine?

This is the line where the error appears: https://github.com/DiscordMessenger/dm/blob/master/src/windows/Main.cpp#L262 (specifically, the dereference of g_pMessageList)

[KontrollFreek]

@KontrollFreek The MinGW symbols builds do not actually show a different stack trace. They're there for transparency. I could just... not provide these builds and keep them on my hard drive, but they're probably useful to somebody.

The symbols builds are literally the exact same code and data, in the exact same order, as in the normal version. I just run strip DiscordMessenger-MinGW-Symbols.exe, and out pops the binary that people usually download.

I figured, I was only asking so that when a stack trace is given the symbols are there for a decompiler or debugger

[iProgramMC]

The symbols and stack trace are there for me. I then use a decompiler to map the addresses to actual code lines.

[KontrollFreek]

well, turns out this is something that happens randomly

[KontrollFreek]

I also managed to get it during the main program loop. I'll attempt to upload a copy of kernel32.dll as well for analysis

[KontrollFreek]

kernel32.dll (catbox.moe)

[iProgramMC]

I hate to do this, but I have a hunch that maybe the emulator is screwed up. Can you try in another VM program?

[iProgramMC]

I also managed to get it during the main program loop. I'll attempt to upload a copy of kernel32.dll as well for analysis

Okay, I've found the cause for this one, this one seems sort of rational. I'll push a fix for this one specifically. The others, I can't diagnose without a stack trace, sorry.

Update: The first reported issue appears to be a failure in the creation of the message list control. I'll add a warning if any one of these fails to allocate.