From db08eabfadc70fd730e1aa4de898f7eaf53887a0 Mon Sep 17 00:00:00 2001 From: Abigail Yates Date: Tue, 18 Aug 2026 10:51:32 +0000 Subject: [PATCH 1/3] make plots fill their parent box and fix tomography resizing issues --- .../spectroscopy/SpectroscopyPlots.tsx | 14 +++++-- .../src/components/tomography/SliceViewer.tsx | 34 +++++++++++++---- .../components/tomography/TomographyPlots.tsx | 38 ++++++++++++------- apps/visr/src/utils/createArrayFromView.ts | 1 + 4 files changed, 63 insertions(+), 24 deletions(-) diff --git a/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx b/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx index 2a2429ce..c59920c7 100644 --- a/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx +++ b/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx @@ -116,13 +116,16 @@ function SpectroscopyPlots({ }> + } + sx={{ display: "flex" }} + > {mounted && ( + + + + + ); } diff --git a/apps/visr/src/components/tomography/TomographyPlots.tsx b/apps/visr/src/components/tomography/TomographyPlots.tsx index 4ce3026c..7605eb59 100644 --- a/apps/visr/src/components/tomography/TomographyPlots.tsx +++ b/apps/visr/src/components/tomography/TomographyPlots.tsx @@ -49,41 +49,51 @@ function TomographyPlots({ plane={plane} />, ]; + const titles = ["Camera View", "Reconstruction", "Slice View"]; + const plots = views.map((view, i) => ( + + {titles[i]} + - - {titles[i]} - + {view} - {view} )); - console.log(plots[0]); + return ( - } color="blue"> + }> {mounted && ( {}} > {plots} diff --git a/apps/visr/src/utils/createArrayFromView.ts b/apps/visr/src/utils/createArrayFromView.ts index 3266f182..0fc5c9b2 100644 --- a/apps/visr/src/utils/createArrayFromView.ts +++ b/apps/visr/src/utils/createArrayFromView.ts @@ -1,6 +1,7 @@ import ndarray, { type NdArray } from "ndarray"; import { assign } from "ndarray-ops"; +//copied (and simplified) from h5web: https://github.com/silx-kit/h5web/blob/a8cceed504b8ab57d426319db56b8b8dab309e3f/packages/shared/src/vis-utils.ts#L103 export default function createArrayFromView( view: NdArray, ): NdArray { From 8a28eedda441a0e72729bfb2d0d2aa482a2a836b Mon Sep 17 00:00:00 2001 From: Abigail Yates Date: Tue, 18 Aug 2026 14:25:22 +0100 Subject: [PATCH 2/3] fix spectroscopy resizing --- .../src/components/spectroscopy/SpectroscopyPlots.tsx | 9 +++++---- apps/visr/src/components/tomography/SliceViewer.tsx | 2 +- apps/visr/src/components/tomography/TomographyPlots.tsx | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx b/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx index c59920c7..011873da 100644 --- a/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx +++ b/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx @@ -116,16 +116,16 @@ function SpectroscopyPlots({ {mounted && ( }> {mounted && ( Date: Tue, 18 Aug 2026 13:30:29 +0000 Subject: [PATCH 3/3] allow plotAspectRatio to be any aspect accepted by Davidia --- apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx | 6 +++--- apps/visr/src/components/spectroscopy/SpectroscopyView.tsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx b/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx index 011873da..0841b358 100644 --- a/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx +++ b/apps/visr/src/components/spectroscopy/SpectroscopyPlots.tsx @@ -84,7 +84,7 @@ export type SpectroscopyData = Partial>; interface SpectroscopyPlotsProps { expanded: boolean; - plotAspectRatio: number; + plotAspectRatio: number | "auto" | "equal"; } function SpectroscopyPlots({ @@ -125,7 +125,7 @@ function SpectroscopyPlots({ > {mounted && (