Skip to content

[ACTP] add bootstrap-par-control command to PAR binary - #54870

Draft
embeaken wants to merge 1 commit into
ilya/par-monolith-e2efrom
ilya/par-ensure-enrollment
Draft

[ACTP] add bootstrap-par-control command to PAR binary#54870
embeaken wants to merge 1 commit into
ilya/par-monolith-e2efrom
ilya/par-ensure-enrollment

Conversation

@embeaken

@embeaken embeaken commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds privateactionrunner bootstrap-par-control, the command par-control runs at
startup. It makes Go the single configuration authority for split mode:

  • loads the canonical Agent configuration (config.NewAgentParams +
    core.Bundle(core.WithSecrets())), so precedence, secrets, endpoint selection
    and Agent file-path resolution are the same ones the Go executor uses;
  • reuses a valid persisted identity for the current host, self-enrolling and
    persisting otherwise;
  • derives the PAR runtime configuration and emits it as a single
    PAR_CONTROL_CONFIG= prefixed JSON line on stdout.

When split mode is disabled it returns only the launch gate and log level and exits
successfully, without hostname lookup, identity access, enrollment, or the FIPS
check. When split mode is active it rejects FIPS mode rather than silently
consuming FIPS-transformed endpoints; a Gov site is not rejected on its own.

OPMS endpoint selection moves into a shared Config.OPMSEndpointURL helper used by
both the Go OPMS client and this command, so the Go and Rust runners cannot diverge
again — including under the fakeintake test switch.

Durations are emitted with explicit _milliseconds units. The payload carries the
runner private key and may carry proxy credentials, so it is never included in an
error.

This replaces the earlier ensure-enrollment command with no compatibility alias;
the enrollment helper and its tests moved rather than being rewritten. Rust no
longer loads or merges Agent configuration — see #54590.

Motivation

par-control previously loaded and merged Agent configuration itself, in Rust. That
duplicated the Go loader and let the two runners disagree; the OPMS endpoint had
already drifted once. Making Go authoritative removes roughly 1,640 lines of Rust
configuration code and the class of bug that goes with it.

Validation

  • bazel test //cmd/privateactionrunner/subcommands/bootstrapparcontrol:bootstrapparcontrol_test
  • bazel test //cmd/privateactionrunner/subcommands/rotateidentity:rotateidentity_test
  • dda inv test --targets=./pkg/privateactionrunner/opms,./pkg/privateactionrunner/adapters/config
  • Exercised against a registered staging runner end to end: bootstrap resolved the
    persisted identity and staging OPMS endpoint, and a UI-triggered
    script.testConnection produced a runPredefinedScript task that was verified,
    executed, and published successfully. The emitted payload never appeared in the
    control-plane log.

@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Go Package Import Differences

Baseline: 296059f
Comparison: e24de5f

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
agentaixppc64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/adapters/constants
privateactionrunnerlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerwindowsamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerdarwinamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerdarwinarm64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/bootstrapparcontrol
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 64.55%
Overall Coverage: 52.63% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e24de5f | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 296059ff:

Results for datadog-agent_7.84.0~devel.git.448.e24de5f.pipeline.132944334-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.448.e24de5f.pipeline.132944334-1_amd64.deb:

No change detected

@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 6c22069 to cd87d21 Compare August 13, 2026 23:04
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 66e117b to e323571 Compare August 13, 2026 23:04
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/action-platform labels Aug 13, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Aug 13, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 296059f
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +24.16 KiB (0.00% increase, -0.69% of buffer) 761.181 → 761.204 → 764.600
agent_msi +25.0 KiB (0.00% increase, -0.18% of buffer) 647.835 → 647.859 → 661.050
agent_rpm_amd64 +24.16 KiB (0.00% increase, -0.69% of buffer) 761.165 → 761.188 → 764.570
agent_rpm_arm64 +20.16 KiB (0.00% increase, -76.93% of buffer) 737.104 → 737.124 → 737.130
agent_suse_amd64 +24.16 KiB (0.00% increase, -0.69% of buffer) 761.165 → 761.188 → 764.570
agent_suse_arm64 +20.16 KiB (0.00% increase, -76.93% of buffer) 737.104 → 737.124 → 737.130
docker_agent_amd64 +24.16 KiB (0.00% increase, -6.22% of buffer) 819.760 → 819.784 → 820.140
docker_agent_arm64 +20.15 KiB (0.00% increase, -11.06% of buffer) 820.712 → 820.732 → 820.890
docker_agent_jmx_amd64 +24.16 KiB (0.00% increase, -9.75% of buffer) 1010.658 → 1010.682 → 1010.900
docker_agent_jmx_arm64 +20.16 KiB (0.00% increase, -6.39% of buffer) 1000.262 → 1000.282 → 1000.570
23 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 713.931 MiB
agent_heroku_amd64 312.896 MiB
agent_rpm_amd64_fips 713.915 MiB
agent_rpm_arm64_fips 693.134 MiB
agent_suse_amd64_fips 713.915 MiB
agent_suse_arm64_fips 693.134 MiB
docker_cluster_agent_amd64 211.423 MiB
docker_cluster_agent_arm64 224.458 MiB
docker_cws_instrumentation_amd64 7.443 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.522 MiB
docker_dogstatsd_arm64 37.623 MiB
docker_host_profiler_amd64 306.843 MiB
docker_host_profiler_arm64 318.121 MiB
dogstatsd_deb_amd64 30.267 MiB
dogstatsd_deb_arm64 28.294 MiB
dogstatsd_rpm_amd64 30.267 MiB
dogstatsd_suse_amd64 30.267 MiB
iot_agent_deb_amd64 46.553 MiB
iot_agent_deb_arm64 43.206 MiB
iot_agent_deb_armhf 44.000 MiB
iot_agent_rpm_amd64 46.554 MiB
iot_agent_suse_amd64 46.553 MiB

@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from cd87d21 to 6ba350e Compare August 13, 2026 23:10
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 2 times, most recently from 1a16146 to 6b010be Compare August 13, 2026 23:48
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 6ba350e to 481cfaf Compare August 13, 2026 23:48
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 14, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: f07c8c69-2ee1-48d4-b3b1-2cf8e699eb7c

Baseline: c45db9e
Comparison: e24de5f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.32 [+0.11, +0.53] 1 Logs
quality_gate_metrics_logs memory utilization +0.17 [-0.06, +0.40] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.16 [+0.04, +0.28] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.14 [+0.05, +0.23] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.02 [-0.03, +0.06] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.04 [-0.08, -0.00] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.09 [-0.12, -0.05] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.19 [-0.24, -0.15] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.61 [-1.48, +0.27] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.86 [-1.10, -0.61] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.06MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 746.33KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 532.37MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 213.00MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.51MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 354.15 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 20 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 405.99MiB ≤ 453MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.99MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 28.69 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 326.99MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.20 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 305.35MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.66 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 310.12MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 6b010be to 00a3402 Compare August 14, 2026 02:43
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 481cfaf to 9960c56 Compare August 14, 2026 02:43
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 00a3402 to ea55c73 Compare August 14, 2026 13:18
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch 2 times, most recently from 9c657ce to 50ccce5 Compare August 14, 2026 14:17
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from ea55c73 to 690bb57 Compare August 14, 2026 14:19
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 50ccce5 to f7b495c Compare August 14, 2026 16:37
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 690bb57 to c2aaa60 Compare August 14, 2026 16:40
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from f7b495c to 787ec32 Compare August 14, 2026 16:48
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 2 times, most recently from 01b23ab to f821eba Compare August 14, 2026 17:53
@embeaken
embeaken marked this pull request as ready for review August 14, 2026 17:55
@embeaken
embeaken requested a review from a team as a code owner August 14, 2026 17:55
@embeaken
embeaken requested a review from hush-hush August 17, 2026 16:01
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 6e4b0d0 to 29fbee2 Compare August 17, 2026 16:01
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch 2 times, most recently from c785c41 to fb58e03 Compare August 17, 2026 17:13
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 29fbee2 to 5d08287 Compare August 17, 2026 17:13
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from fb58e03 to 4fdaf12 Compare August 17, 2026 20:01
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 5d08287 to efcffd4 Compare August 17, 2026 20:03
Comment thread cmd/privateactionrunner/subcommands/ensureenrollment/command.go Outdated
Base automatically changed from ilya/par-control-lifecycle to main August 18, 2026 14:33
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 672b028 to d6f8b60 Compare August 18, 2026 14:43
@embeaken
embeaken requested a review from hush-hush August 18, 2026 14:43
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from d6f8b60 to 3c1138d Compare August 18, 2026 18:21
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 3 times, most recently from 4673145 to 725764e Compare August 19, 2026 19:11
@embeaken
embeaken marked this pull request as draft August 19, 2026 20:06
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 3 times, most recently from eff670d to e53fe05 Compare August 21, 2026 22:06
@embeaken
embeaken changed the base branch from main to ilya/par-monolith-e2e August 21, 2026 22:07
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 2 times, most recently from 0075a35 to f1e6a0d Compare August 21, 2026 23:56
@embeaken
embeaken force-pushed the ilya/par-monolith-e2e branch from b43a153 to 48eda5c Compare August 23, 2026 01:00
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from f1e6a0d to 8bdfbbc Compare August 23, 2026 01:04
@embeaken
embeaken force-pushed the ilya/par-monolith-e2e branch from 48eda5c to 9a8d25c Compare August 24, 2026 13:59
Make Go the single configuration authority for Private Action Runner split
mode. `privateactionrunner bootstrap-par-control` loads the canonical Agent
configuration, ensures enrollment, and emits the resolved control-plane
configuration as one PAR_CONTROL_CONFIG= prefixed JSON line, so par-control no
longer has to independently load or merge Agent configuration.

When split mode is disabled the command returns the launch gate and log level
and exits successfully, without hostname lookup, identity access, enrollment,
or FIPS rejection. When split mode is active it rejects FIPS mode rather than
silently consuming FIPS-transformed endpoints; a Gov site is not rejected on
its own.

OPMS endpoint selection moves to a shared Config.OPMSEndpointURL helper used by
both the Go OPMS client and this command, so the Go and Rust runners cannot
diverge again, including under the fakeintake test switch.

Durations are emitted with explicit _milliseconds units, and the payload is
never included in an error because it carries the runner private key and may
carry proxy credentials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/action-platform team/agent-build team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants