From 882e989322828ccf3cfa95af5565c26b8362feaf Mon Sep 17 00:00:00 2001 From: Krathe Date: Tue, 16 Jun 2026 17:51:58 +0100 Subject: [PATCH 1/3] Fix Show Buffs/Show Debuffs toggles not applying live until reload The Show Buffs / Show Debuffs checkbox callbacks ran DF:UpdateAllFrames(), which only re-applies frame layout and leaves aura updates to UNIT_AURA events. The actual show/hide gate lives in DF:UpdateAuras_Enhanced, so an already-shown aura kept its state until the unit's next aura event (or a /reload). Buffs appeared to update instantly only because they churn often; a static debuff lingered. Switch both callbacks to DF:RefreshAllVisibleFrames(), which re-runs the aura scan per visible frame (RefreshLiveFrames -> FullFrameRefresh -> UpdateAuras) - the same refresh the adjacent Max Buffs/Max Debuffs sliders already use. --- Changelog.lua | 1 + Options/Options.lua | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Changelog.lua b/Changelog.lua index acf1f271..a483e71b 100644 --- a/Changelog.lua +++ b/Changelog.lua @@ -29,6 +29,7 @@ DF.CHANGELOG_TEXT = [===[ * (Missing Buff) The missing-buff icon no longer flags a **cross-faction group member in the open world** as needing a buff you can't actually cast on them — it only appears where the buff is castable (e.g. inside instances). (by Krathe) * (Defensive Icon) The defensive cooldown icon and its border now render **above auras** and stay co-planar with the icon. (by Krathe) * (Role Icons) **Show Tank / Healer / DPS** toggles now apply live without a `/reload`, and are properly decoupled from the Hide-in-Combat gate. (by Krathe) +* (Buff/Debuff) **Show Buffs / Show Debuffs** toggles now apply live without a `/reload` — already-shown auras hide or reappear immediately instead of lingering until the unit's next aura change. (by Krathe) * (Raid Frames) Fixed missing frames for players who are still loading in, such as battleground backfills joining mid-match. (by Krathe) * (Aura Designer) Text-only icons no longer draw a leftover border (static or expiring). (by Krathe) * (Aura Designer) Aura icon and square borders from older profiles keep their original look after the border rework, instead of appearing thinner or floating in a gap. (by Krathe) diff --git a/Options/Options.lua b/Options/Options.lua index af85f6cb..572df9aa 100644 --- a/Options/Options.lua +++ b/Options/Options.lua @@ -5831,7 +5831,11 @@ function DF:SetupGUIPages(GUI, CreateCategory, CreateSubTab, BuildPage) settingsGroup:AddWidget(GUI:CreateHeader(self.child, L["Settings"]), 40) local showBuffsCb = settingsGroup:AddWidget(GUI:CreateCheckbox(self.child, L["Show Buffs"], db, "showBuffs", function() self:RefreshStates() - DF:UpdateAllFrames() + -- Re-scan auras on visible frames (not just layout): the show/hide gate + -- lives in the UNIT_AURA-driven UpdateAuras path, so UpdateAllFrames alone + -- (layout-only) leaves already-shown auras until the next aura event. Use + -- the same refresh the Max Buffs slider uses. + DF:RefreshAllVisibleFrames() end), 30) -- Re-sync checked state when value changes externally (e.g. AD banner click) showBuffsCb.refreshContent = function(self) @@ -6040,7 +6044,9 @@ function DF:SetupGUIPages(GUI, CreateCategory, CreateSubTab, BuildPage) settingsGroup:AddWidget(GUI:CreateHeader(self.child, L["Settings"]), 40) settingsGroup:AddWidget(GUI:CreateCheckbox(self.child, L["Show Debuffs"], db, "showDebuffs", function() self:RefreshStates() - DF:UpdateAllFrames() + -- See Show Buffs above: re-scan auras on visible frames so a static + -- debuff hides/shows immediately instead of waiting for the next aura event. + DF:RefreshAllVisibleFrames() end), 30) local dispelHighlight = settingsGroup:AddWidget(GUI:CreateCheckbox(self.child, L["Highlight Dispellable"], db, "dispellableHighlight", nil), 30) dispelHighlight.disableOn = function(d) return not d.showDebuffs end From 16a5699deb4429aa87b610ff765b6c033d501856 Mon Sep 17 00:00:00 2001 From: Krathe Date: Tue, 16 Jun 2026 21:18:47 +0100 Subject: [PATCH 2/3] Changelog: add #165 entry to CHANGELOG.md (the build's source) --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a275570c..6e657141 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ * (Aura Designer) Text-only icons no longer draw a leftover border (static or expiring). (by Krathe) * (Aura Designer) Aura icon and square borders from older profiles keep their original look after the border rework, instead of appearing thinner or floating in a gap. (by Krathe) * (Buff/Debuff) Icon borders from older profiles no longer float in a gap after the border rework — they hug the icon as before. (by Krathe) +* (Buff/Debuff) **Show Buffs / Show Debuffs** toggles now apply live without a `/reload` — already-shown auras hide or reappear immediately instead of lingering until the unit's next aura change. (by Krathe) ## [4.4.1] From ea4a8cb74299a81ce1d72e7b00c1d97493bd40ad Mon Sep 17 00:00:00 2001 From: Krathe Date: Wed, 17 Jun 2026 00:16:38 +0100 Subject: [PATCH 3/3] Changelog: drop Changelog.lua edit (generated from CHANGELOG.md at build) --- Changelog.lua | 1 - 1 file changed, 1 deletion(-) diff --git a/Changelog.lua b/Changelog.lua index a483e71b..acf1f271 100644 --- a/Changelog.lua +++ b/Changelog.lua @@ -29,7 +29,6 @@ DF.CHANGELOG_TEXT = [===[ * (Missing Buff) The missing-buff icon no longer flags a **cross-faction group member in the open world** as needing a buff you can't actually cast on them — it only appears where the buff is castable (e.g. inside instances). (by Krathe) * (Defensive Icon) The defensive cooldown icon and its border now render **above auras** and stay co-planar with the icon. (by Krathe) * (Role Icons) **Show Tank / Healer / DPS** toggles now apply live without a `/reload`, and are properly decoupled from the Hide-in-Combat gate. (by Krathe) -* (Buff/Debuff) **Show Buffs / Show Debuffs** toggles now apply live without a `/reload` — already-shown auras hide or reappear immediately instead of lingering until the unit's next aura change. (by Krathe) * (Raid Frames) Fixed missing frames for players who are still loading in, such as battleground backfills joining mid-match. (by Krathe) * (Aura Designer) Text-only icons no longer draw a leftover border (static or expiring). (by Krathe) * (Aura Designer) Aura icon and square borders from older profiles keep their original look after the border rework, instead of appearing thinner or floating in a gap. (by Krathe)