IIUC this is the equivalent of the GaudiApplication + RunApplication + AnalyseXMLSummary modules.
I have a few comments here, again if you agree but don't have the time, just open issues as a reminder (you don't need to elaborate much, I will add further details):
- this
run_lbprodrun.py module should be located in the modules directory with the other apps used within the CWL workflows.
- any reason for using
argparse rather than typer?
- we can try to see again with Chris, but IIRC, we said that the
AnalyseXMLSummary should also be a PostProcess command because we need to set the status of files when there are issues. So basically here we could potentially fail if the XMLsummary is not right, and save the problematic files to report in a PostProcess commands. What do you think?
- Also, we would need to make sure that features of
GaudiApplication + RunApplication are all present here, and from the discussions we had I don't think it's the case (?). I did that a few months ago, but I don't even remember if it was complete (https://gitlab.cern.ch/lhcb-dirac/LHCbDIRAC/-/blob/8594e5b75f6f957040571c99551b32b5a1587bb5/src/LHCbDIRAC/WorkloadManagementSystem/JobWrapper/LbProdRunApp.py).
Originally posted by @aldbr in #94 (comment)
IIUC this is the equivalent of the
GaudiApplication + RunApplication + AnalyseXMLSummarymodules.I have a few comments here, again if you agree but don't have the time, just open issues as a reminder (you don't need to elaborate much, I will add further details):
run_lbprodrun.pymodule should be located in themodulesdirectory with the other apps used within the CWL workflows.argparserather thantyper?AnalyseXMLSummaryshould also be a PostProcess command because we need to set the status of files when there are issues. So basically here we could potentially fail if the XMLsummary is not right, and save the problematic files to report in a PostProcess commands. What do you think?GaudiApplication + RunApplicationare all present here, and from the discussions we had I don't think it's the case (?). I did that a few months ago, but I don't even remember if it was complete (https://gitlab.cern.ch/lhcb-dirac/LHCbDIRAC/-/blob/8594e5b75f6f957040571c99551b32b5a1587bb5/src/LHCbDIRAC/WorkloadManagementSystem/JobWrapper/LbProdRunApp.py).Originally posted by @aldbr in #94 (comment)