Release: develop -> main#3834
Merged
Merged
Conversation
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
…instead of KycRequired (#3836) * fix(realunit): offer NewRegistration empty form for first-time users instead of KycRequired getRegistrationInfo dead-ended onboarding for any wallet without pre-fillable KYC data: it returned KycRequired, which the client surfaces as a terminal "complete your identity verification first" failure — yet that is exactly the first-time user the registration flow exists to onboard. completeRegistration requires only KYC Level 10 (email) and persists manually-entered data when no prior data exists, so the form must be offered, not withheld. Return NewRegistration with userData omitted (empty form) when neither a registration step nor pre-fill data exist; the existing prefill path is unchanged. KycRequired is kept as a reserved, no-longer-emitted contract value so clients retain explicit handling. Regression introduced in #3782. * fix(realunit): drop unemitted KycRequired registration state (YAGNI)
TaprootFreak
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist