requirements.txt parsing breaks on inline comments

[Erquint]

## ComfyUI-Manager: EXECUTE =>
['E:\\Programs\\Runtimes\\ComfyUI\\venv\\Scripts\\python.exe', '-m', 'pip',
'install', 'matplotlib>=3.3.0  # For visualization in test scripts']
ERROR: Invalid requirement: 'matplotlib>=3.3.0  # For visualization in test scripts': Expected comma (within version specifier), semicolon (after version specifier) or end
    matplotlib>=3.3.0  # For visualization in test scripts
              ~~~~~~~~~^
Traceback (most recent call last):
  File "E:\Programs\Runtimes\ComfyUI\venv\Lib\site-packages\comfyui_manager\legacy\manager_core.py", line 1350, in repo_install
    if not postinstall():
           ^^^^^^^^^^^^^
  File "E:\Programs\Runtimes\ComfyUI\venv\Lib\site-packages\comfyui_manager\legacy\manager_core.py", line 1345, in postinstall
    return self.execute_install_script(url, repo_path, instant_execution=instant_execution, no_deps=no_deps)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\Programs\Runtimes\ComfyUI\venv\Lib\site-packages\comfyui_manager\legacy\manager_core.py", line 852, in execute_install_script
    res = res and try_install_script(url, repo_path, install_cmd, instant_execution=instant_execution)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\Programs\Runtimes\ComfyUI\venv\Lib\site-packages\comfyui_manager\legacy\manager_core.py", line 1860, in try_install_script
    code = manager_funcs.run_script(install_cmd, cwd=repo_path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\Programs\Runtimes\ComfyUI\venv\Lib\site-packages\comfyui_manager\legacy\manager_core.py", line 1662, in run_script
    subprocess.check_call(cmd, cwd=cwd, env=get_script_env())
  File "C:\Users\Erquint\AppData\Local\Programs\Python\Python312\Lib\subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['E:\\Programs\\Runtimes\\ComfyUI\\venv\\Scripts\\python.exe', '-m', 'pip', 'install', 'matplotlib>=3.3.0  # For visualization in test scripts']' returned non-zero exit status 1.
ERROR: An error occurred while installing
'comfyui-eric-image-processing-nodes'.
Install(git-clone) error[2]:
https://github.com/EricRollei/Eric_Image_Processing_Nodes / Command
'['E:\\Programs\\Runtimes\\ComfyUI\\venv\\Scripts\\python.exe', '-m', 'pip',
'install', 'matplotlib>=3.3.0  # For visualization in test scripts']' returned
non-zero exit status 1.

The workaround that helps is…

1. (venv) PS E:\Programs\Runtimes\ComfyUI> comfy node install comfyui-eric-image-processing-nodes@latest --no-deps
2. (venv) PS E:\Programs\Runtimes\ComfyUI> python -m pip install -r E:\Programs\Runtimes\ComfyUI\installation\custom_nodes\comfyui-eric-image-processing-nodes\requirements.txt

Because the native PIP requirements installer doesn't choke on inline comments. You somehow implement it incorrectly.

Additionally, this failure seems to leave git objects in a locked state out of sync with ComfyUI's normal operation, so it fails to even uninstall correctly afterwards, but that's a whole can of worms that should be manageably avoided if you fix this bug…

[dosubot]

Hi @Erquint! I'm Dosu and I’m helping the comfy-cli team.

This is a confirmed bug in comfy-cli's requirements.txt parsing. When installing custom node dependencies line-by-line, inline comments are not stripped before being passed to pip install.

In execute_install_script(), each line from requirements.txt is read, stripped of whitespace, and checked for full-line comments (# at the start), but inline comments like matplotlib>=3.3.0 # For visualization in test scripts are passed to pip as-is — causing the Invalid requirement error.

The same issue exists in parse_req_file() in uv.py.

The fix would be to strip inline comments before appending the requirement, e.g.:

line = line.split("#")[0].strip()

Note: pip install -r requirements.txt handles this natively because pip's own requirements parser strips inline comments per PEP 508. The bug only manifests when comfy-cli parses lines itself and passes them individually to pip install.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}
   

[Erquint]

👀 Or just run python -m pip install -r under the hood, sheesh…
Either way should be a trivial fix and a forehead-slapper for being overlooked.