London | 26-ITP-May | Damilola Odumosu| Sprint 1 | Form Controls#1347
London | 26-ITP-May | Damilola Odumosu| Sprint 1 | Form Controls#1347d-odumosu wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d-odumosu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
d-odumosu
changed the title
d-odumosu
added
the
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you achieve a lighthouse score of 100?
There was a problem hiding this comment.
Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows.
There was a problem hiding this comment.
I also added a main tag and a meta content description to the head as recommended when i did the lighthouse testing.
| <div class="form-group"> | ||
| <label for="firstname">First Name </label> | ||
| <input | ||
| type="text" | ||
| id="firstname" | ||
| name="firstname" | ||
| required | ||
| pattern="^[A-Za-z\s'-]{2,}$" |
There was a problem hiding this comment.
Good job on the indentation. This makes the code easier to read.
| id="lastname" | ||
| name="lastname" | ||
| required | ||
| pattern="^[A-Za-z\s'-]{2,}$" |
There was a problem hiding this comment.
The browser console shows an error here when I fill out the form
index.html?firstname=%C3%A4%C3%A4&lastname=%C3%A4%C3%A4&email=dada%40test.com&shirt=blue&size=small:1 Pattern attribute value ^[A-Za-z\s'-]{2,}$ is not a valid regular expression: Uncaught SyntaxError: Invalid regular expression: /^[A-Za-z\s'-]{2,}$/v: Invalid character in character class
There was a problem hiding this comment.
I have now fixed the pattern error
Luro91
added
Reviewed
2 participants
London | 26-ITP-May | Damilola Odumosu| Sprint 1 | Form Controls
Learners, PR Template
Self checklist
Changelist
Completed the form controls fulfilling all the requirements set out in the read me.