Skip to content

Birmingham|26-ITP-May|LesyaLyaisyan|Sprint 1|Form-Controls#1335

Open
LesyaLyan wants to merge 8 commits into
CodeYourFuture:mainfrom
LesyaLyan:feature/form-controls
Open

Birmingham|26-ITP-May|LesyaLyaisyan|Sprint 1|Form-Controls#1335
LesyaLyan wants to merge 8 commits into
CodeYourFuture:mainfrom
LesyaLyan:feature/form-controls

Conversation

@LesyaLyan
Copy link
Copy Markdown

@LesyaLyan LesyaLyan commented May 22, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR creates a T-shirt order form using semantic HTML. It collects the user’s name, email, colour, and size.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7905e6f
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1252f49f268a0008d086ba
😎 Deploy Preview https://deploy-preview-1335--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@LesyaLyan LesyaLyan added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@LesyaLyan LesyaLyan changed the title Birmingham|26-ITP-May|LesyaLyaisyan|Sprint1|Form-Controls Birmingham|26-ITP-May|LesyaLyaisyan|Sprint 1|Form-Controls May 22, 2026
@LesyaLyan LesyaLyan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026
@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 23, 2026
Luro91
Luro91 reviewed May 23, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Lighhouse score SEO is at 90. How could you get to 100?

Image

Comment thread Form-Controls/README.md
Comment on lines +37 to +38
- [] I have only used HTML and CSS.
- [] I have not used any JavaScript.
Copy link
Copy Markdown

@Luro91 Luro91 May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

Copy link
Copy Markdown
Author

@LesyaLyan LesyaLyan May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta description has been added, now SEO is 100 :) all the changes are in a commit. Thanks

Copy link
Copy Markdown

@Luro91 Luro91 May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the Readme change?

Comment thread Form-Controls/style.css
Copy link
Copy Markdown

@Luro91 Luro91 May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce that you moved the styling into a seperate file. It helps keeping the responsibilites of the code clear

Comment thread Form-Controls/index.html Outdated

<hr>
<label for="name">Full Name</label>
<input id="name" name="name" type="text" minlength="2" placeholder="First Name Surname" pattern="[A-Za-z ]{2,}" required>
Copy link
Copy Markdown

@Luro91 Luro91 May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents special characters like the German ä, ü, ö. How coul you allow them as well?

Copy link
Copy Markdown
Author

@LesyaLyan LesyaLyan May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the name pattern using a Unicode letter class to allow special characters.

Comment thread Form-Controls/index.html Outdated
<main>
<form>

<hr>
Copy link
Copy Markdown

@Luro91 Luro91 May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?

Copy link
Copy Markdown
Author

@LesyaLyan LesyaLyan May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML is formatted automatically now by using a code formatter :) I didn't have it installed on my VSCode.

Copy link
Copy Markdown

@Luro91 Luro91 May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. You could configure it so that it automatically runs whenever you save the file

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 23, 2026
@LesyaLyan LesyaLyan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 24, 2026
Luro91
Luro91 reviewed May 24, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme file is still changed.

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Luro91 Luro91 Luro91 left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LesyaLyan @Luro91