Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control#1264
Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control#1264yonasdesbelegebre wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
yonasdesbelegebre
added
the
Needs Review
Luro91
added
the
Review in progress
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="XL">XL</option> | ||
| <option vallue="XXL">XXL</optio> |
There was a problem hiding this comment.
I see 4 errors in the w3 validator https://validator.w3.org/nu/#textarea
| <div> | ||
| <label for="customeremail">Customer email: </label> | ||
| <input type="email" id="customeremail" name="customeremail" required | ||
| pattern="^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$" |
There was a problem hiding this comment.
This does not allow special charcaters like the German ä,ü,ö
There was a problem hiding this comment.
Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows.
There was a problem hiding this comment.
Why are there changes in this file? How is it related to the task?
| <style> | ||
| input:valid{ | ||
| border:2px solid yellow; | ||
| } | ||
| input:invalid:not(:placeholder-shown){ | ||
| border:2px solid red; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Why is this code not in the CSS file as well?
| <div> | ||
| <label for="customername">Customer name *: </label> | ||
| <input type="text" id="customername" name="customername" required |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?
Luro91
added
Reviewed
3 participants
Learners, PR Template
Self checklist
Changelist
The form collects customer names and email addresses, as well as t-shirt sizes and colors.
The inputs are all required.
For customer names, it is only possible to use characters.
For the email, I use a regular expression.
For t-shirt colors, there are 3 available choices as radio type with colors black, red, and blue.
For T-shirt , i use select one from the list of 6 sizes.
Styles for the form and elements.