From 12e6bd0f80fdcc3383a027dca5c9b9af3547c87a Mon Sep 17 00:00:00 2001
From: Miyo Sho <135030944+yuri-kiss@users.noreply.github.com>
Date: Tue, 19 May 2026 15:07:54 -0400
Subject: [PATCH] fix: password inputs not saving

---
 src/addons/settings-store.js | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/addons/settings-store.js b/src/addons/settings-store.js
index 6270e246c43..d8ec076ed1a 100644
--- a/src/addons/settings-store.js
+++ b/src/addons/settings-store.js
@@ -289,7 +289,17 @@ class SettingsStore extends EventTargetShim {
                 if (typeof value !== 'number') {
                     throw new Error('Setting value is invalid.');
                 }
-            } else if (settingObject.type === 'string' || settingObject.type === 'long_string' || settingObject.type === 'untranslated') {
+            } else if (
+                settingObject.type === 'string' ||
+                settingObject.type === 'long_string' ||
+                settingObject.type === 'untranslated'
+            ) {
+                // always valid
+            } else if (
+                settingObject.type === 'password' ||
+                settingObject.type === 'long_password'
+            ) {
+                value = String(value);
                 // always valid
             } else if (settingObject.type === 'color') {
                 if (typeof value !== 'string') {
@@ -309,7 +319,7 @@ class SettingsStore extends EventTargetShim {
                     throw new Error('Setting value is invalid.');
                 }
             } else {
-                throw new Error('Setting object is of unknown type');
+                throw new Error(`Setting object is of unknown type: ${settingObject.type}`);
             }
             storage[settingId] = value;
         }