Skip to content

Private JWInventoryAPI fields are modified directly #17

Description

@CYooBin10

Labels: medium, bug, compatibility, menu

Description

The plugin directly modifies internal JWInventoryAPI fields:

  • inv._dirty_slots.clear()
  • inv._batch_mode = False

These fields are private implementation details and are not part of a stable public API.

Impact

  • JWInventoryAPI updates can break the menu without warning.
  • Batch state may not be finalized correctly.
  • Inventory refreshes can become inconsistent.
  • Dirty-slot tracking may be corrupted.

Expected behavior

Use the dependency's public batch completion and inventory refresh APIs.

If no public API exists, one should be added to JWInventoryAPI instead of mutating private state.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions