Skip to content

Use milliseconds everywhere #8932

Description

@nflaig

discussion: maybe we should use milliseconds everywhere in metrics

Originally posted by @wemeetagain in #8838 (comment)

To clarify, I think we should use milliseconds but when passing values to metrics we need to use seconds (prometheus best practices) and all our metrics are _seconds. It would be good if this can be handled internally by our metric register, ie. caller passes as milliseconds and it gets converted to seconds internally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions